Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2032733003: Reland "Move (hopefully) remaining isolate related variables to toolchain.gypi" (Closed)

Created:
4 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Move (hopefully) remaining isolate related variables to toolchain.gypi" BUG=chromium:609107 R=machenbach@chromium.org Committed: https://crrev.com/09d90e4e70819607b76bdd2bd4f23be3922b9050 Cr-Commit-Position: refs/heads/master@{#36677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M gypfiles/standalone.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M gypfiles/toolchain.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 6 months ago (2016-06-02 09:29:01 UTC) #1
Michael Achenbach
lgtm
4 years, 6 months ago (2016-06-02 09:38:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032733003/1
4 years, 6 months ago (2016-06-02 09:40:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 09:55:00 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 09:55:54 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/09d90e4e70819607b76bdd2bd4f23be3922b9050
Cr-Commit-Position: refs/heads/master@{#36677}

Powered by Google App Engine
This is Rietveld 408576698