net/http/bidirectional_stream_impl.h - Issue 2032733002: Do not crash on null stream in writing to bidirectional streams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/bidirectional_stream_impl.h

Issue 2032733002: Do not crash on null stream in writing to bidirectional streams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_crash

Patch Set: Address Andrei's comments round 2 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/bidirectional_stream_impl.h

diff --git a/net/http/bidirectional_stream_impl.h b/net/http/bidirectional_stream_impl.h

index 38cac64f03b3f3098394b76e855cf4d1956a51a5..4f53918ef1df506f7712d01959adc03190ed9b78 100644

--- a/net/http/bidirectional_stream_impl.h

+++ b/net/http/bidirectional_stream_impl.h

@@ -74,8 +74,8 @@ class NET_EXPORT_PRIVATE BidirectionalStreamImpl {

// EOF has not been received, or to send data if there is no pending send.

virtual void OnTrailersReceived(const SpdyHeaderBlock& trailers) = 0;

- // Called when an error occurred.

- // No other delegate functions will be called after this.

+ // Called when an error occurred. Do not call into the stream after this

+ // point. No other delegate functions will be called after this.

virtual void OnFailed(int status) = 0;

protected:

« no previous file with comments | « net/http/bidirectional_stream.h ('k') | net/net.gypi » ('j') | no next file with comments »