Underline Thickness is not uniform

Source/core/rendering/InlineFlowBox.cpp

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 1115 matching lines @@
     }
 
     if (paintInfo.phase == PaintPhaseMask)
         return;
 
     PaintPhase paintPhase = paintInfo.phase == PaintPhaseChildOutlines ? PaintPhaseOutline : paintInfo.phase;
     PaintInfo childInfo(paintInfo);
     childInfo.phase = paintPhase;
     childInfo.updatePaintingRootForChildren(&renderer());
 
-    // Paint our children.
+    float decorationThickness = 0;

[leviw_travelin_and_unemployed, 2014/03/21 20:43:08]

These should be scoped inside the if.

+    float finalThickness = 0;
+
+    // Paint our childrens and calculate underline thickness

[leviw_travelin_and_unemployed, 2014/03/21 20:43:08]

s/childrens/children/, but I don't think this comment adds much.

     if (paintPhase != PaintPhaseSelfOutline) {
         for (InlineBox* curr = firstChild(); curr; curr = curr->nextOnLine()) {
-            if (curr->renderer().isText() || !curr->boxModelObject()->hasSelfPaintingLayer())
+            if (curr->renderer().isText() || !curr->boxModelObject()->hasSelfPaintingLayer()) {
                 curr->paint(childInfo, paintOffset, lineTop, lineBottom);
+                curr->getPaintDecorationSyle(childInfo, paintOffset, &decorationThickness);

[leviw_travelin_and_unemployed, 2014/03/21 20:43:08]

Why not have this method return decorationThickness instead of using an out
parameter? Then you could do something like max(decorationThickness,
curr->getPaintDecocrationStyle)

+                if (finalThickness < decorationThickness)
+                    finalThickness = decorationThickness;
+            }
+        }
+
+        // We have underline thickness now, let draw it

[leviw_travelin_and_unemployed, 2014/03/21 20:43:08]

s/let/lets/, but again I don't think this comment is helpful.

+        for (InlineBox* curr = firstChild(); curr; curr = curr->nextOnLine()) {
+            if (curr->renderer().isText() || !curr->boxModelObject()->hasSelfPaintingLayer()) {
+                curr->paintDecorationStyle(childInfo, paintOffset, lineTop, lineBottom, finalThickness);
+            }
         }
     }
 }
 
 void InlineFlowBox::paintFillLayers(const PaintInfo& paintInfo, const Color& c, const FillLayer* fillLayer, const LayoutRect& rect, CompositeOperator op)
 {
     if (!fillLayer)
         return;
     paintFillLayers(paintInfo, c, fillLayer->next(), rect, op);
     paintFillLayer(paintInfo, c, fillLayer, rect, op);
@@ skipping 492 matching lines @@
         ASSERT(child->prevOnLine() == prev);
         prev = child;
     }
     ASSERT(prev == m_lastChild);
 #endif
 }
 
 #endif
 
 } // namespace WebCore