Underline Thickness is not uniform

Source/core/rendering/style/RenderStyleConstants.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 345 matching lines @@
     TextDecorationNone = 0x0,
     TextDecorationUnderline = 0x1,
     TextDecorationOverline = 0x2,
     TextDecorationLineThrough = 0x4,
     TextDecorationBlink = 0x8
 };
 inline TextDecoration operator| (TextDecoration a, TextDecoration b) { return TextDecoration(int(a) | int(b)); }
 inline TextDecoration& operator|= (TextDecoration& a, TextDecoration b) { return a = a | b; }
 
 enum TextDecorationStyle {
+    TextDecorationStyleNone,

[andersr, 2014/03/19 13:18:12]

Are you sure you need this?

The decoration style can't be "none" per spec, and I don't think the value is
needed internally either. Existence of decorations is controlled by
text-decoration-line (enum TextDecoration), not by text-decoration-style.

See http://www.w3.org/TR/css-text-decor-3/#text-decoration-style-property

[h.joshi, 2014/03/19 13:59:54]

Yes as per CSS doc "none" is not a defined value, I used it  as initial value
when we do not know the decoration style. Assigning one of the values defined
does not looked good to me.
Pls suggest

On 2014/03/19 13:18:12, rude wrote:

[andersr, 2014/03/19 14:39:44]

The correct value in that case is TextDecorationStyleSolid. (See spec).

(Although I suggest that you drop this chunk, and don't mess with
TextDecorationStyle at all in this patch. See other comment).

     TextDecorationStyleSolid,
     TextDecorationStyleDouble,
     TextDecorationStyleDotted,
     TextDecorationStyleDashed,
     TextDecorationStyleWavy
 };
 
 enum TextAlignLast {
     TextAlignLastAuto, TextAlignLastStart, TextAlignLastEnd, TextAlignLastLeft, TextAlignLastRight, TextAlignLastCenter, TextAlignLastJustify
 };
@@ skipping 177 matching lines @@
 // Reasonable maximum to prevent insane font sizes from causing crashes on some platforms (such as Windows).
 static const float maximumAllowedFontSize = 1000000.0f;
 
 enum TextIndentLine { TextIndentFirstLine, TextIndentEachLine };
 
 enum LayoutBox { BoxMissing = 0, MarginBox, BorderBox, PaddingBox, ContentBox };
 
 } // namespace WebCore
 
 #endif // RenderStyleConstants_h