Chromium Code Reviews

Side by Side Diff: Source/core/rendering/InlineBox.cpp

Issue 203273003: Underline Thickness is not uniform (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 183 matching lines...)
194 if (!paintInfo.shouldPaintWithinRoot(&renderer()) || (paintInfo.phase != Pai ntPhaseForeground && paintInfo.phase != PaintPhaseSelection)) 194 if (!paintInfo.shouldPaintWithinRoot(&renderer()) || (paintInfo.phase != Pai ntPhaseForeground && paintInfo.phase != PaintPhaseSelection))
195 return; 195 return;
196 196
197 LayoutPoint childPoint = paintOffset; 197 LayoutPoint childPoint = paintOffset;
198 if (parent()->renderer().style()->isFlippedBlocksWritingMode()) // Faster th an calling containingBlock(). 198 if (parent()->renderer().style()->isFlippedBlocksWritingMode()) // Faster th an calling containingBlock().
199 childPoint = renderer().containingBlock()->flipForWritingModeForChild(&t oRenderBox(renderer()), childPoint); 199 childPoint = renderer().containingBlock()->flipForWritingModeForChild(&t oRenderBox(renderer()), childPoint);
200 200
201 RenderBlock::paintAsInlineBlock(&renderer(), paintInfo, childPoint); 201 RenderBlock::paintAsInlineBlock(&renderer(), paintInfo, childPoint);
202 } 202 }
203 203
204 void InlineBox::paintDecorationStyle(PaintInfo& paintInfo, const LayoutPoint& pa intOffset, LayoutUnit lineTop, LayoutUnit lineBottom, float underlineThickness)
205 {
206 return;
207 }
208
209 void InlineBox::getPaintDecorationSyle(PaintInfo& paintInfo, const LayoutPoint& paintOffset, float * underlineThickness, TextDecorationStyle * style)
210 {
211 return;
212 }
213
andersr 2014/03/19 13:18:12 These could just appear in the header as: void [g
h.joshi 2014/03/19 13:59:54 Yes, will make required changes. On 2014/03/19 13
204 bool InlineBox::nodeAtPoint(const HitTestRequest& request, HitTestResult& result , const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffs et, LayoutUnit /* lineTop */, LayoutUnit /*lineBottom*/) 214 bool InlineBox::nodeAtPoint(const HitTestRequest& request, HitTestResult& result , const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffs et, LayoutUnit /* lineTop */, LayoutUnit /*lineBottom*/)
205 { 215 {
206 // Hit test all phases of replaced elements atomically, as though the replac ed element established its 216 // Hit test all phases of replaced elements atomically, as though the replac ed element established its
207 // own stacking context. (See Appendix E.2, section 6.4 on inline block/tab le elements in the CSS2.1 217 // own stacking context. (See Appendix E.2, section 6.4 on inline block/tab le elements in the CSS2.1
208 // specification.) 218 // specification.)
209 LayoutPoint childPoint = accumulatedOffset; 219 LayoutPoint childPoint = accumulatedOffset;
210 if (parent()->renderer().style()->isFlippedBlocksWritingMode()) // Faster th an calling containingBlock(). 220 if (parent()->renderer().style()->isFlippedBlocksWritingMode()) // Faster th an calling containingBlock().
211 childPoint = renderer().containingBlock()->flipForWritingModeForChild(&t oRenderBox(renderer()), childPoint); 221 childPoint = renderer().containingBlock()->flipForWritingModeForChild(&t oRenderBox(renderer()), childPoint);
212 222
213 return renderer().hitTest(request, result, locationInContainer, childPoint); 223 return renderer().hitTest(request, result, locationInContainer, childPoint);
(...skipping 145 matching lines...)
359 b->showTreeForThis(); 369 b->showTreeForThis();
360 } 370 }
361 371
362 void showLineTree(const WebCore::InlineBox* b) 372 void showLineTree(const WebCore::InlineBox* b)
363 { 373 {
364 if (b) 374 if (b)
365 b->showLineTreeForThis(); 375 b->showLineTreeForThis();
366 } 376 }
367 377
368 #endif 378 #endif
OLDNEW

Powered by Google App Engine