Put SimpleOffsetFilter on heap.

Put SimpleOffsetFilter on heap.

Effects want to live on the heap!

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13848

[mtklein, 2014-03-18 09:41:34]

I am playing around with picture recording and noticed this one effect was not
on the heap, and so not ref-able.

[Dominik Grewe, 2014-03-18 09:47:21]

On 2014/03/18 09:41:34, mtklein wrote:
> I am playing around with picture recording and noticed this one effect was not
> on the heap, and so not ref-able.

Thanks for catching that! Must have missed it in my previous CL:
https://codereview.chromium.org/182983003/

Can you make the constructor for SimpleOffsetFilter private and provide a
factory method instead? That's what we've done for all other subclasses of
SkImageFilter to ensure we never allocate them on the stack.

[Dominik Grewe, 2014-03-18 09:50:40]

On 2014/03/18 09:47:21, Dominik Grewe wrote:
> On 2014/03/18 09:41:34, mtklein wrote:
> > I am playing around with picture recording and noticed this one effect was
not
> > on the heap, and so not ref-able.
> 
> Thanks for catching that! Must have missed it in my previous CL:
> https://codereview.chromium.org/182983003/
> 
> Can you make the constructor for SimpleOffsetFilter private and provide a
> factory method instead? That's what we've done for all other subclasses of
> SkImageFilter to ensure we never allocate them on the stack.

Might be worth looking into whether we can enforce this for all subclasses
somehow...

[mtklein, 2014-03-18 09:51:52]

> Might be worth looking into whether we can enforce this for all subclasses
> somehow...
Agreed.

PTAL?

[Dominik Grewe, 2014-03-18 10:03:26]

On 2014/03/18 09:51:52, mtklein wrote:
> > Might be worth looking into whether we can enforce this for all subclasses
> > somehow...
> Agreed.
> 
> PTAL?

LGTM, thanks!

[mtklein, 2014-03-18 10:12:34]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-03-18 10:12:45]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/203273002/40001

[commit-bot: I haz the power, 2014-03-18 10:12:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-18 10:12:46]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[mtklein, 2014-03-18 10:12:59]

lgtm

[mtklein, 2014-03-18 10:13:02]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-03-18 10:13:04]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/203273002/40001

[commit-bot: I haz the power, 2014-03-18 10:28:29]

Change committed as 13848