Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2032713004: Use #969696 as (dark) text hint color in the Android omnibox. (Closed)

Created:
4 years, 6 months ago by Bernhard Bauer
Modified:
4 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use #969696 as (dark) text hint color in the Android omnibox. BUG=616710 Committed: https://crrev.com/6f0fe45868ed6241b5bcbd08f1d12be2bd1b0e67 Cr-Commit-Position: refs/heads/master@{#397740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/android/java/res/values/colors.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bernhard Bauer
Please review. Thanks!
4 years, 6 months ago (2016-06-03 14:21:24 UTC) #2
Ted C
lgtm
4 years, 6 months ago (2016-06-03 16:31:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032713004/1
4 years, 6 months ago (2016-06-03 16:32:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 17:20:29 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 17:21:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f0fe45868ed6241b5bcbd08f1d12be2bd1b0e67
Cr-Commit-Position: refs/heads/master@{#397740}

Powered by Google App Engine
This is Rietveld 408576698