Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2032713003: [regexp] fix subtle bug in RegExpTest. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] fix subtle bug in RegExpTest. R=bmeurer@chromium.org Committed: https://crrev.com/7ca611d1a59ecc5fb95525517bde169ed6934136 Cr-Commit-Position: refs/heads/master@{#36670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/js/regexp.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 6 months ago (2016-06-02 07:29:30 UTC) #1
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-02 07:36:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032713003/1
4 years, 6 months ago (2016-06-02 07:36:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 08:03:48 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 08:04:41 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7ca611d1a59ecc5fb95525517bde169ed6934136
Cr-Commit-Position: refs/heads/master@{#36670}

Powered by Google App Engine
This is Rietveld 408576698