content/renderer/render_frame_impl.cc - Issue 2032653003: Limit foreign fetch to only intercept requests made from secure contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2032653003: Limit foreign fetch to only intercept requests made from secure contexts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: properly initialize new ResourceRequest member Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/resource_request.h ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index bc920bb8454fca5e7bccffb50ab68d0fd5609f0a..e8ccd7e53d759892f5d1499da02aef7a47217d40 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -4025,6 +4025,9 @@ void RenderFrameImpl::willSendRequest(

extra_data->set_lofi_state(navigation_state->common_params().lofi_state);

else

extra_data->set_lofi_state(is_using_lofi_ ? LOFI_ON : LOFI_OFF);

+ WebString error;

+ extra_data->set_initiated_in_secure_context(

+ frame->document().isSecureContext(error));

request.setExtraData(extra_data);

// TODO(creis): Update prefetching to work with out-of-process iframes.