cc/ipc/shared_quad_state.typemap - Issue 2032643002: Implement cc::SharedQuadState StructTraits

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/ipc/shared_quad_state.typemap

Issue 2032643002: Implement cc::SharedQuadState StructTraits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed StructTraits + added unittest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 mojom = "//cc/ipc/shared_quad_state.mojom"

	6 public_headers = [ "//cc/quads/shared_quad_state.h" ]

	7 traits_headers = [ "//cc/ipc/shared_quad_state_struct_traits.h" ]

	8 deps = [ "//cc", ]

	9 public_deps = [ "//cc", ]

	10 type_mappings = [ "cc.mojom.SharedQuadState=std::unique_ptr<cc::SharedQuadState> " ]
	danakj 2016/06/01 20:54:11 why the unique_ptr? why the unique_ptr? Fady Samuel 2016/06/01 21:02:49 cc::SharedQuadState is missing a copy constructor. Show quoted text On 2016/06/01 20:54:11, danakj wrote: > why the unique_ptr? cc::SharedQuadState is missing a copy constructor. We don't allow the default constructor it seems for complex types so I solved that by passing it around via unique_ptr. I could give cc::SharedQuadState a copy constructor? WDYT? I think this becomes a problem with mojo::Array<cc::SharedQuadState> which uses std::vector under the hood and I believe all the entries in an std::vector are copied when it resizes. danakj 2016/06/01 21:04:20 vector moves things when it resizes if there is a Show quoted text On 2016/06/01 21:02:49, Fady Samuel wrote: > On 2016/06/01 20:54:11, danakj wrote: > > why the unique_ptr? > > > cc::SharedQuadState is missing a copy constructor. We don't allow the default > constructor it seems for complex types so I solved that by passing it around via > unique_ptr. I could give cc::SharedQuadState a copy constructor? WDYT? > > I think this becomes a problem with mojo::Array<cc::SharedQuadState> which uses > std::vector under the hood and I believe all the entries in an std::vector are > copied when it resizes. vector moves things when it resizes if there is a move constructor. Maybe you need to add that.
OLD	NEW

« cc/ipc/shared_quad_state.mojom ('K') | « cc/ipc/shared_quad_state.mojom ('k') | cc/ipc/shared_quad_state_struct_traits.h » ('j') | no next file with comments »