Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: Source/web/ChromeClientImpl.cpp

Issue 203263004: Remove didChangeValueInTextField(HTMLInputElement&) and textFieldDidChange(const WebInputElement&) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 903 matching lines...) Expand 10 before | Expand all | Expand 10 after
914 914
915 webFrame->client()->forwardInputEvent(&webEvent); 915 webFrame->client()->forwardInputEvent(&webEvent);
916 } else if (event->isWheelEvent()) { 916 } else if (event->isWheelEvent()) {
917 WebMouseWheelEventBuilder webEvent(webFrame->frameView(), document->rend erer(), *static_cast<WebCore::WheelEvent*>(event)); 917 WebMouseWheelEventBuilder webEvent(webFrame->frameView(), document->rend erer(), *static_cast<WebCore::WheelEvent*>(event));
918 if (webEvent.type == WebInputEvent::Undefined) 918 if (webEvent.type == WebInputEvent::Undefined)
919 return; 919 return;
920 webFrame->client()->forwardInputEvent(&webEvent); 920 webFrame->client()->forwardInputEvent(&webEvent);
921 } 921 }
922 } 922 }
923 923
924 // FIXME: This function is to be removed once both chromium and blink changes
925 // for BUG332557 are in.
926 void ChromeClientImpl::didChangeValueInTextField(HTMLInputElement& inputElement)
927 {
928 if (!m_webView->autofillClient())
929 return;
930 m_webView->autofillClient()->textFieldDidChange(WebInputElement(&inputElemen t));
931 }
932
933 void ChromeClientImpl::didChangeValueInTextField(HTMLFormControlElement& element ) 924 void ChromeClientImpl::didChangeValueInTextField(HTMLFormControlElement& element )
934 { 925 {
935 if (!m_webView->autofillClient()) 926 if (!m_webView->autofillClient())
936 return; 927 return;
937 m_webView->autofillClient()->textFieldDidChange(WebFormControlElement(&eleme nt)); 928 m_webView->autofillClient()->textFieldDidChange(WebFormControlElement(&eleme nt));
938 } 929 }
939 930
940 void ChromeClientImpl::didEndEditingOnTextField(HTMLInputElement& inputElement) 931 void ChromeClientImpl::didEndEditingOnTextField(HTMLInputElement& inputElement)
941 { 932 {
942 if (m_webView->autofillClient()) 933 if (m_webView->autofillClient())
(...skipping 25 matching lines...) Expand all
968 { 959 {
969 return static_cast<NavigatorContentUtilsClient::CustomHandlersState>(m_webVi ew->client()->isProtocolHandlerRegistered(scheme, baseURL, url)); 960 return static_cast<NavigatorContentUtilsClient::CustomHandlersState>(m_webVi ew->client()->isProtocolHandlerRegistered(scheme, baseURL, url));
970 } 961 }
971 962
972 void NavigatorContentUtilsClientImpl::unregisterProtocolHandler(const String& sc heme, const WebCore::KURL& baseURL, const WebCore::KURL& url) 963 void NavigatorContentUtilsClientImpl::unregisterProtocolHandler(const String& sc heme, const WebCore::KURL& baseURL, const WebCore::KURL& url)
973 { 964 {
974 m_webView->client()->unregisterProtocolHandler(scheme, baseURL, url); 965 m_webView->client()->unregisterProtocolHandler(scheme, baseURL, url);
975 } 966 }
976 967
977 } // namespace blink 968 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698