core/fpdfapi/fpdf_font/cpdf_simplefont.h - Issue 2032613003: Get rid of NULLs in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_font/cpdf_simplefont.h

Issue 2032613003: Get rid of NULLs in core/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Fix a bad merge Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_font/cpdf_simplefont.h

diff --git a/core/fpdfapi/fpdf_font/cpdf_simplefont.h b/core/fpdfapi/fpdf_font/cpdf_simplefont.h

index 7b07c9971ea44457203906488ea7ec65825b9bb7..881744a4054f6feb1b4d37452d35f9fb467a7e95 100644

--- a/core/fpdfapi/fpdf_font/cpdf_simplefont.h

+++ b/core/fpdfapi/fpdf_font/cpdf_simplefont.h

@@ -20,7 +20,8 @@ class CPDF_SimpleFont : public CPDF_Font {

// CPDF_Font:

int GetCharWidthF(uint32_t charcode, int level = 0) override;

FX_RECT GetCharBBox(uint32_t charcode, int level = 0) override;

- int GlyphFromCharCode(uint32_t charcode, FX_BOOL* pVertGlyph = NULL) override;

+ int GlyphFromCharCode(uint32_t charcode,

+ FX_BOOL* pVertGlyph = nullptr) override;

FX_BOOL IsUnicodeCompatible() const override;

CFX_WideString UnicodeFromCharCode(uint32_t charcode) const override;

uint32_t CharCodeFromUnicode(FX_WCHAR Unicode) const override;