Get rid of NULLs in core/

core/fxcrt/include/fx_system.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_FXCRT_INCLUDE_FX_SYSTEM_H_
 #define CORE_FXCRT_INCLUDE_FX_SYSTEM_H_
 
 #include <assert.h>
@@ skipping 73 matching lines @@
 
 #ifndef FALSE
 #define FALSE 0
 #endif
 
 #ifdef __cplusplus
 static_assert(TRUE == true, "true_needs_to_be_true");
 static_assert(FALSE == false, "false_needs_to_be_false");
 #endif
 
-#ifndef NULL
-#define NULL 0
+#ifndef nullptr

[Tom Sepez, 2016/06/02 20:09:49]

Let's not do this.  Let's keep it NULL for things that may include this.

[Lei Zhang, 2016/06/07 07:33:24]

I ended up removing this in one of the later patch sets and all the trybots were
green.

+#define nullptr 0
 #endif
 
 #ifndef ASSERT
 #ifndef NDEBUG
 #define ASSERT assert
 #else
 #define ASSERT(a)
 #endif
 #endif
 
@@ skipping 226 matching lines @@
 
 // Prevent a function from ever being inlined, typically because we'd
 // like it to appear in stack traces.
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
 #define NEVER_INLINE __declspec(noinline)
 #else  // _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
 #define NEVER_INLINE __attribute__((__noinline__))
 #endif  // _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
 
 #endif  // CORE_FXCRT_INCLUDE_FX_SYSTEM_H_