Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Side by Side Diff: core/fxcrt/include/fx_ext.h

Issue 2032613003: Get rid of NULLs in core/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Fix a bad merge Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fxcrt/include/fx_basic.h ('k') | core/fxcrt/include/fx_system.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FXCRT_INCLUDE_FX_EXT_H_ 7 #ifndef CORE_FXCRT_INCLUDE_FX_EXT_H_
8 #define CORE_FXCRT_INCLUDE_FX_EXT_H_ 8 #define CORE_FXCRT_INCLUDE_FX_EXT_H_
9 9
10 #include <cctype> 10 #include <cctype>
11 #include <cwctype> 11 #include <cwctype>
12 12
13 #include "core/fxcrt/include/fx_basic.h" 13 #include "core/fxcrt/include/fx_basic.h"
14 14
15 #define FX_INVALID_OFFSET static_cast<uint32_t>(-1) 15 #define FX_INVALID_OFFSET static_cast<uint32_t>(-1)
16 16
17 // TODO(thestig) Using unique_ptr with ReleaseDeleter is still not ideal. 17 // TODO(thestig) Using unique_ptr with ReleaseDeleter is still not ideal.
18 // Come up or wait for something better. This appears in this file rather 18 // Come up or wait for something better. This appears in this file rather
19 // than fx_stream.h due to include ordering restrictions. 19 // than fx_stream.h due to include ordering restrictions.
20 using ScopedFileStream = 20 using ScopedFileStream =
21 std::unique_ptr<IFX_FileStream, ReleaseDeleter<IFX_FileStream>>; 21 std::unique_ptr<IFX_FileStream, ReleaseDeleter<IFX_FileStream>>;
22 22
23 FX_FLOAT FXSYS_tan(FX_FLOAT a); 23 FX_FLOAT FXSYS_tan(FX_FLOAT a);
24 FX_FLOAT FXSYS_logb(FX_FLOAT b, FX_FLOAT x); 24 FX_FLOAT FXSYS_logb(FX_FLOAT b, FX_FLOAT x);
25 FX_FLOAT FXSYS_strtof(const FX_CHAR* pcsStr, 25 FX_FLOAT FXSYS_strtof(const FX_CHAR* pcsStr,
26 int32_t iLength = -1, 26 int32_t iLength = -1,
27 int32_t* pUsedLen = NULL); 27 int32_t* pUsedLen = nullptr);
28 FX_FLOAT FXSYS_wcstof(const FX_WCHAR* pwsStr, 28 FX_FLOAT FXSYS_wcstof(const FX_WCHAR* pwsStr,
29 int32_t iLength = -1, 29 int32_t iLength = -1,
30 int32_t* pUsedLen = NULL); 30 int32_t* pUsedLen = nullptr);
31 FX_WCHAR* FXSYS_wcsncpy(FX_WCHAR* dstStr, const FX_WCHAR* srcStr, size_t count); 31 FX_WCHAR* FXSYS_wcsncpy(FX_WCHAR* dstStr, const FX_WCHAR* srcStr, size_t count);
32 int32_t FXSYS_wcsnicmp(const FX_WCHAR* s1, const FX_WCHAR* s2, size_t count); 32 int32_t FXSYS_wcsnicmp(const FX_WCHAR* s1, const FX_WCHAR* s2, size_t count);
33 int32_t FXSYS_strnicmp(const FX_CHAR* s1, const FX_CHAR* s2, size_t count); 33 int32_t FXSYS_strnicmp(const FX_CHAR* s1, const FX_CHAR* s2, size_t count);
34 34
35 inline bool FXSYS_islower(int32_t ch) { 35 inline bool FXSYS_islower(int32_t ch) {
36 return ch >= 'a' && ch <= 'z'; 36 return ch >= 'a' && ch <= 'z';
37 } 37 }
38 inline bool FXSYS_isupper(int32_t ch) { 38 inline bool FXSYS_isupper(int32_t ch) {
39 return ch >= 'A' && ch <= 'Z'; 39 return ch >= 'A' && ch <= 'Z';
40 } 40 }
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 j -= gap; 123 j -= gap;
124 } 124 }
125 pArray[j + gap] = v1; 125 pArray[j + gap] = v1;
126 } 126 }
127 gap >>= 1; 127 gap >>= 1;
128 } 128 }
129 } 129 }
130 }; 130 };
131 131
132 #endif // CORE_FXCRT_INCLUDE_FX_EXT_H_ 132 #endif // CORE_FXCRT_INCLUDE_FX_EXT_H_
OLDNEW
« no previous file with comments | « core/fxcrt/include/fx_basic.h ('k') | core/fxcrt/include/fx_system.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698