Get rid of NULLs in core/

core/fxcodec/codec/fx_codec_tiff.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fxcodec/codec/codec_int.h"
 #include "core/fxcodec/include/fx_codec.h"
 #include "core/fxge/include/fx_dib.h"
 
@@ skipping 55 matching lines @@
   FX_BOOL Decode24bppRGB(CFX_DIBitmap* pDIBitmap,
                          int32_t height,
                          int32_t width,
                          uint16_t bps,
                          uint16_t spp);
 };
 CCodec_TiffContext::CCodec_TiffContext() {
   offset = 0;
   frame_num = 0;
   frame_cur = 0;
-  io.in = NULL;
-  tif_ctx = NULL;
-  icc_ctx = NULL;
+  io.in = nullptr;
+  tif_ctx = nullptr;
+  icc_ctx = nullptr;
   isDecoder = TRUE;
 }
 CCodec_TiffContext::~CCodec_TiffContext() {
   if (icc_ctx) {
     IccLib_DestroyTransform(icc_ctx);
-    icc_ctx = NULL;
+    icc_ctx = nullptr;
   }
   if (tif_ctx) {
     TIFFClose(tif_ctx);
   }
 }
 static tsize_t _tiff_read(thandle_t context, tdata_t buf, tsize_t length) {
   CCodec_TiffContext* pTiffContext = (CCodec_TiffContext*)context;
   FX_BOOL ret = FALSE;
   if (pTiffContext->isDecoder) {
     ret = pTiffContext->io.in->ReadBlock(buf, pTiffContext->offset, length);
@@ skipping 91 matching lines @@
 TIFFErrorHandler _TIFFerrorHandler = nullptr;
 
 int TIFFCmyk2Rgb(thandle_t context,
                  uint8 c,
                  uint8 m,
                  uint8 y,
                  uint8 k,
                  uint8* r,
                  uint8* g,
                  uint8* b) {
-  if (context == NULL) {
+  if (!context)
     return 0;
-  }
+
   CCodec_TiffContext* p = (CCodec_TiffContext*)context;
   if (p->icc_ctx) {
     unsigned char cmyk[4], bgr[3];
     cmyk[0] = c, cmyk[1] = m, cmyk[2] = y, cmyk[3] = k;
     IccLib_TranslateImage(p->icc_ctx, bgr, cmyk, 1);
     *r = bgr[2], *g = bgr[1], *b = bgr[0];
   } else {
     AdobeCMYK_to_sRGB1(c, m, y, k, *r, *g, *b);
   }
   return 1;
 }
 FX_BOOL CCodec_TiffContext::InitDecoder(IFX_FileRead* file_ptr) {
   io.in = file_ptr;
-  tif_ctx = _tiff_open(this, "r");
-  if (tif_ctx == NULL) {
-    return FALSE;
-  }
-  return TRUE;
+  return !!_tiff_open(this, "r");
 }
 void CCodec_TiffContext::GetFrames(int32_t& frames) {
   frames = frame_num = TIFFNumberOfDirectories(tif_ctx);
 }
 #define TIFF_EXIF_GETINFO(key, T, tag)      \
   {                                         \
     T val = (T)0;                           \
     TIFFGetField(tif_ctx, tag, &val);       \
     if (val) {                              \
       (key) = FX_Alloc(uint8_t, sizeof(T)); \
       if ((key)) {                          \
         T* ptr = (T*)(key);                 \
         *ptr = val;                         \
         pExif->m_TagVal.SetAt(tag, (key));  \
       }                                     \
     }                                       \
   }                                         \
-  (key) = NULL;
+  (key) = nullptr;
 #define TIFF_EXIF_GETSTRINGINFO(key, tag)    \
   {                                          \
     uint32_t size = 0;                       \
-    uint8_t* buf = NULL;                     \
+    uint8_t* buf = nullptr;                  \
     TIFFGetField(tif_ctx, tag, &size, &buf); \
     if (size && buf) {                       \
       (key) = FX_Alloc(uint8_t, size);       \
       if ((key)) {                           \
         FXSYS_memcpy((key), buf, size);      \
         pExif->m_TagVal.SetAt(tag, (key));   \
       }                                      \
     }                                        \
   }                                          \
-  (key) = NULL;
+  (key) = nullptr;
 
 namespace {
 
 template <class T>
 FX_BOOL Tiff_Exif_GetInfo(TIFF* tif_ctx, ttag_t tag, CFX_DIBAttribute* pAttr) {
   T val = 0;
   TIFFGetField(tif_ctx, tag, &val);
   if (!val)
     return FALSE;
   T* ptr = FX_Alloc(T, 1);
@@ skipping 21 matching lines @@
                                           uint32_t& width,
                                           uint32_t& height,
                                           uint32_t& comps,
                                           uint32_t& bpc,
                                           CFX_DIBAttribute* pAttribute) {
   if (!TIFFSetDirectory(tif_ctx, (uint16)frame)) {
     return FALSE;
   }
   uint16_t tif_cs;
   uint32_t tif_icc_size = 0;
-  uint8_t* tif_icc_buf = NULL;
+  uint8_t* tif_icc_buf = nullptr;
   uint16_t tif_bpc = 0;
   uint16_t tif_cps;
   uint32_t tif_rps;
   width = height = comps = 0;
   TIFFGetField(tif_ctx, TIFFTAG_IMAGEWIDTH, &width);
   TIFFGetField(tif_ctx, TIFFTAG_IMAGELENGTH, &height);
   TIFFGetField(tif_ctx, TIFFTAG_SAMPLESPERPIXEL, &comps);
   TIFFGetField(tif_ctx, TIFFTAG_BITSPERSAMPLE, &tif_bpc);
   TIFFGetField(tif_ctx, TIFFTAG_PHOTOMETRIC, &tif_cs);
   TIFFGetField(tif_ctx, TIFFTAG_COMPRESSION, &tif_cps);
@@ skipping 91 matching lines @@
                                           int32_t width,
                                           uint16_t bps,
                                           uint16_t spp) {
   if (pDIBitmap->GetBPP() != 1 || spp != 1 || bps != 1 ||
       !isSupport(pDIBitmap)) {
     return FALSE;
   }
   SetPalette(pDIBitmap, bps);
   int32_t size = (int32_t)TIFFScanlineSize(tif_ctx);
   uint8_t* buf = (uint8_t*)_TIFFmalloc(size);
-  if (buf == NULL) {
+  if (!buf) {
     TIFFError(TIFFFileName(tif_ctx), "No space for scanline buffer");
     return FALSE;
   }
   uint8_t* bitMapbuffer = (uint8_t*)pDIBitmap->GetBuffer();
   uint32_t pitch = pDIBitmap->GetPitch();
   for (int32_t row = 0; row < height; row++) {
     TIFFReadScanline(tif_ctx, buf, row, 0);
     for (int32_t j = 0; j < size; j++) {
       bitMapbuffer[row * pitch + j] = buf[j];
     }
   }
   _TIFFfree(buf);
   return TRUE;
 }
 FX_BOOL CCodec_TiffContext::Decode8bppRGB(CFX_DIBitmap* pDIBitmap,
                                           int32_t height,
                                           int32_t width,
                                           uint16_t bps,
                                           uint16_t spp) {
   if (pDIBitmap->GetBPP() != 8 || spp != 1 || (bps != 4 && bps != 8) ||
       !isSupport(pDIBitmap)) {
     return FALSE;
   }
   SetPalette(pDIBitmap, bps);
   int32_t size = (int32_t)TIFFScanlineSize(tif_ctx);
   uint8_t* buf = (uint8_t*)_TIFFmalloc(size);
-  if (buf == NULL) {
+  if (!buf) {
     TIFFError(TIFFFileName(tif_ctx), "No space for scanline buffer");
     return FALSE;
   }
   uint8_t* bitMapbuffer = (uint8_t*)pDIBitmap->GetBuffer();
   uint32_t pitch = pDIBitmap->GetPitch();
   for (int32_t row = 0; row < height; row++) {
     TIFFReadScanline(tif_ctx, buf, row, 0);
     for (int32_t j = 0; j < size; j++) {
       switch (bps) {
         case 4:
@@ skipping 12 matching lines @@
 FX_BOOL CCodec_TiffContext::Decode24bppRGB(CFX_DIBitmap* pDIBitmap,
                                            int32_t height,
                                            int32_t width,
                                            uint16_t bps,
                                            uint16_t spp) {
   if (pDIBitmap->GetBPP() != 24 || !isSupport(pDIBitmap)) {
     return FALSE;
   }
   int32_t size = (int32_t)TIFFScanlineSize(tif_ctx);
   uint8_t* buf = (uint8_t*)_TIFFmalloc(size);
-  if (buf == NULL) {
+  if (!buf) {
     TIFFError(TIFFFileName(tif_ctx), "No space for scanline buffer");
     return FALSE;
   }
   uint8_t* bitMapbuffer = (uint8_t*)pDIBitmap->GetBuffer();
   uint32_t pitch = pDIBitmap->GetPitch();
   for (int32_t row = 0; row < height; row++) {
     TIFFReadScanline(tif_ctx, buf, row, 0);
     for (int32_t j = 0; j < size - 2; j += 3) {
       bitMapbuffer[row * pitch + j + 0] = buf[j + 2];
       bitMapbuffer[row * pitch + j + 1] = buf[j + 1];
@@ skipping 64 matching lines @@
 }
 
 FX_BOOL CCodec_TiffModule::Decode(CCodec_TiffContext* ctx,
                                   class CFX_DIBitmap* pDIBitmap) {
   return ctx->Decode(pDIBitmap);
 }
 
 void CCodec_TiffModule::DestroyDecoder(CCodec_TiffContext* ctx) {
   delete ctx;
 }