Migrate WaitableEvent to enum-based constructor in base/

base/threading/thread_perftest.cc

Index: base/threading/thread_perftest.cc
diff --git a/base/threading/thread_perftest.cc b/base/threading/thread_perftest.cc
index 5958f1aa6de792f6d8c32c0246504a93446793b0..9d69ac36e499838365b691654e97339f285530eb 100644
--- a/base/threading/thread_perftest.cc
+++ b/base/threading/thread_perftest.cc
@@ -35,7 +35,8 @@ const int kNumRuns = 100000;
 class ThreadPerfTest : public testing::Test {
  public:
   ThreadPerfTest()
-      : done_(false, false) {
+      : done_(WaitableEvent::ResetPolicy::AUTOMATIC,
+              WaitableEvent::InitialState::NOT_SIGNALED) {
     // Disable the task profiler as it adds significant cost!
     CommandLine::Init(0, NULL);
     CommandLine::ForCurrentProcess()->AppendSwitchASCII(
@@ -59,7 +60,8 @@ class ThreadPerfTest : public testing::Test {
   }
 
   base::ThreadTicks ThreadNow(base::Thread* thread) {
-    base::WaitableEvent done(false, false);
+    base::WaitableEvent done(WaitableEvent::ResetPolicy::AUTOMATIC,
+                             WaitableEvent::InitialState::NOT_SIGNALED);
     base::ThreadTicks ticks;
     thread->task_runner()->PostTask(
         FROM_HERE, base::Bind(&ThreadPerfTest::TimeOnThread,
@@ -179,7 +181,9 @@ class EventPerfTest : public ThreadPerfTest {
  public:
   void Init() override {
     for (size_t i = 0; i < threads_.size(); i++)
-      events_.push_back(new WaitableEventType(false, false));
+      events_.push_back(
+          new WaitableEventType(WaitableEvent::ResetPolicy::AUTOMATIC,
+                                WaitableEvent::InitialState::NOT_SIGNALED));

[gab, 2016/06/01 19:16:05]

@etienneb: weird that clang-tidy made this change given not all instantiations
of this template are happy with it.

This is causing compile failures for patch set #1.

I'll undo it for now and do it manually on its own.

[etienneb, 2016/06/01 19:53:27]

You can use this to avoid template instantiation.

  isInTemplateInstantiation() or unless(...)

But, to know if something depend on the instantiation, class Expression has this
function: clang::Expr::isInstantiationDependent
 
http://clang.llvm.org/doxygen/classclang_1_1Expr.html#ae6915a41dbc08e0c2ce21a...

I don't remember if there is a matcher, but you can easily write one.

   }
 
   void Reset() override { events_.clear(); }