Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2032573002: views: Fix a couple of flaky tests on windows/linux, disable them on mus. (Closed)

Created:
4 years, 6 months ago by sadrul
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: Fix a couple of flaky tests on windows/linux, disable them on mus. We can no longer expect a single cycle of message-loop iteration to paint a widget, since painting is now driven by BeginFrameSource. So update the tests to wait for the painting to happen first. These tests create desktop-widgets, which we do not support in mus, so disable the tests in mus. BUG=596039 Committed: https://crrev.com/3845af20c5138df223fd0fba3eb5a275aacea6b8 Cr-Commit-Position: refs/heads/master@{#397206}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -27 lines) Patch
M ui/views/widget/widget_unittest.cc View 1 2 5 chunks +36 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sadrul
4 years, 6 months ago (2016-06-01 16:50:21 UTC) #2
sky
LGTM https://codereview.chromium.org/2032573002/diff/20001/ui/views/widget/widget_unittest.cc File ui/views/widget/widget_unittest.cc (right): https://codereview.chromium.org/2032573002/diff/20001/ui/views/widget/widget_unittest.cc#newcode1402 ui/views/widget/widget_unittest.cc:1402: if (IsMus()) Can you link this and the ...
4 years, 6 months ago (2016-06-01 17:18:27 UTC) #3
sadrul
https://codereview.chromium.org/2032573002/diff/20001/ui/views/widget/widget_unittest.cc File ui/views/widget/widget_unittest.cc (right): https://codereview.chromium.org/2032573002/diff/20001/ui/views/widget/widget_unittest.cc#newcode1402 ui/views/widget/widget_unittest.cc:1402: if (IsMus()) On 2016/06/01 17:18:27, sky wrote: > Can ...
4 years, 6 months ago (2016-06-01 18:28:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032573002/40001
4 years, 6 months ago (2016-06-01 18:32:39 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-01 19:30:24 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 19:31:49 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3845af20c5138df223fd0fba3eb5a275aacea6b8
Cr-Commit-Position: refs/heads/master@{#397206}

Powered by Google App Engine
This is Rietveld 408576698