Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2032553002: Fix Skia windows GN build (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
_cary, Tom Sepez, caryclark
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix Skia windows GN build This CL updates the GN files so the Skia port will build on Windows. This does not mean the functionaly is correct, just that the binaries link. Committed: https://pdfium.googlesource.com/pdfium/+/386b19e03f3915ae22f8c96029b10270e7faa75f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M skia/BUILD.gn View 2 chunks +3 lines, -9 lines 0 comments Download
M skia/skia_gn_files.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-01 16:16:37 UTC) #2
caryclark
lgtm Works great! Thanks!
4 years, 6 months ago (2016-06-01 16:49:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032553002/1
4 years, 6 months ago (2016-06-01 16:50:03 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 16:50:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/386b19e03f3915ae22f8c96029b10270e7fa...

Powered by Google App Engine
This is Rietveld 408576698