Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 203253006: Don't call ill-balanced removeStyleSheetCandidateNode() (Closed)

Created:
6 years, 9 months ago by Hajime Morrita
Modified:
6 years, 9 months ago
Reviewers:
eseidel, ojan
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Visibility:
Public.

Description

Don't call ill-balanced removeStyleSheetCandidateNode() There are possibilities where removeStyleSheetCandidateNode() is called without addStyleSheetCandidateNode(). We should prevent this because StyleEngine assumes that its call is balanced. This change add a flag to ensure it being balanced. BUG=353525 R=ojan@chromium.org, eseidel@chromium.org TEST=style-onload-remove-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169691

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
A LayoutTests/fast/dom/HTMLStyleElement/style-onload-remove-crash.html View 1 chunk +19 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLStyleElement/style-onload-remove-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/dom/StyleElement.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/dom/StyleElement.cpp View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Hajime Morrita
PTAL?
6 years, 9 months ago (2014-03-18 23:07:14 UTC) #1
Hajime Morrita
Ojan, Eric: Ping? This is a crash fix.
6 years, 9 months ago (2014-03-19 17:30:26 UTC) #2
ojan
lgtm
6 years, 9 months ago (2014-03-19 19:53:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/203253006/1
6 years, 9 months ago (2014-03-19 19:53:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 20:03:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-19 20:03:55 UTC) #6
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-19 20:11:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/203253006/1
6 years, 9 months ago (2014-03-19 20:12:09 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 20:25:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-19 20:25:33 UTC) #10
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-19 22:51:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/203253006/1
6 years, 9 months ago (2014-03-19 22:51:54 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 23:27:39 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-19 23:27:39 UTC) #14
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-20 21:00:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/203253006/1
6 years, 9 months ago (2014-03-20 21:00:54 UTC) #16
Hajime Morrita
6 years, 9 months ago (2014-03-20 21:01:59 UTC) #17
Message was sent while issue was closed. 
Committed patchset #1 manually as r169691 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698