git cl issue 0 should really clear issue.

git cl issue 0 should really clear issue.

It used to clear just issue number and patchset, but that's not
all state that associates a given branch with codereview site.

R=andybons@chromium.org
BUG=609295
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300683

[tandrii(chromium), 2016-06-01 13:14:02]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 13:14:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2032433003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2032433003/1

[commit-bot: I haz the power, 2016-06-01 13:15:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 13:15:57]

Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[tandrii(chromium), 2016-06-01 13:20:47]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 13:20:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2032433003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2032433003/20001

[commit-bot: I haz the power, 2016-06-01 13:24:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 13:24:08]

Dry run: This issue passed the CQ dry run.

[Bons, 2016-06-01 13:24:16]

LGTM

The CL description should be updated. It has the older change description I
reviewed in there as well.

https://codereview.chromium.org/2032433003/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2032433003/diff/20001/git_cl.py#newcode1750
git_cl.py:1750: """Which branch-specific properties to erase when unsettin
issue."""
Unsetting

https://codereview.chromium.org/2032433003/diff/20001/git_cl.py#newcode2110
git_cl.py:2110: """Which branch-specific properties to erase when unsettin
issue."""
unsetting

[tandrii(chromium), 2016-06-01 13:40:33]

Description was changed from

==========
git cl issue 0 should really clear issue.

It used to clear just issue number and patchset, but that's not
all state that associates a given branch with codereview site.

R=andybons@chromium.org
BUG=609295

git cl upload: die when --no-squash has no commit-msg-hook.

Otherwise, the program continues, and an exception is printed.
The message is still there, but easy to miss.

R=andybons@chromium.org
==========

to

==========
git cl issue 0 should really clear issue.

It used to clear just issue number and patchset, but that's not
all state that associates a given branch with codereview site.

R=andybons@chromium.org
BUG=609295
==========

[tandrii(chromium), 2016-06-01 13:41:54]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-06-01 13:41:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org
Link to the patchset: https://codereview.chromium.org/2032433003/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2016-06-01 13:42:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2032433003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2032433003/40001

[tandrii(chromium), 2016-06-01 13:42:17]

description fixed, thanks!

https://codereview.chromium.org/2032433003/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2032433003/diff/20001/git_cl.py#newcode1750
git_cl.py:1750: """Which branch-specific properties to erase when unsettin
issue."""
On 2016/06/01 13:24:16, Bons wrote:
> Unsetting

Done.

https://codereview.chromium.org/2032433003/diff/20001/git_cl.py#newcode2110
git_cl.py:2110: """Which branch-specific properties to erase when unsettin
issue."""
On 2016/06/01 13:24:16, Bons wrote:
> unsetting

Done.

[commit-bot: I haz the power, 2016-06-01 13:45:21]

Description was changed from

==========
git cl issue 0 should really clear issue.

It used to clear just issue number and patchset, but that's not
all state that associates a given branch with codereview site.

R=andybons@chromium.org
BUG=609295
==========

to

==========
git cl issue 0 should really clear issue.

It used to clear just issue number and patchset, but that's not
all state that associates a given branch with codereview site.

R=andybons@chromium.org
BUG=609295

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300683
==========

[commit-bot: I haz the power, 2016-06-01 13:45:22]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300683