MD WebUI: Add loading spinner to cr-toolbar, hook into MD History toolbar

chrome/browser/resources/md_history/app.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @typedef {{querying: boolean,
  *            searchTerm: string,
  *            results: ?Array<!HistoryEntry>,
  *            info: ?HistoryQuery,
  *            range: HistoryRange,
@@ skipping 22 matching lines @@
     // TODO(calamity): Split out readOnly data into a separate property which is
     // only set on result return.
     queryState_: {
       type: Object,
       value: function() {
         return {
           // A query is initiated by page load.
           querying: true,
           searchTerm: '',
           results: null,
+          // Whether the most recent query was incremental.
+          incremental: false,
           info: null,
           range: HistoryRange.ALL_TIME,
           // TODO(calamity): Make history toolbar buttons change the offset.
           groupedOffset: 0,
           sessionList: null,
         };
       }
     },
   },
 
@@ skipping 115 matching lines @@
   /**
    * Queries the history backend for results based on queryState_.
    * @param {boolean} incremental Whether the new query should continue where
    *    the previous query stopped.
    */
   queryHistory: function(incremental) {
     if (this.queryingDisabled_ || this.firstLoad_)
       return;
 
     this.set('queryState_.querying', true);
+    this.set('queryState_.incremental', incremental);
 
     var queryState = this.queryState_;
 
     var lastVisitTime = 0;
     if (incremental) {
       var lastVisit = queryState.results.slice(-1)[0];
       lastVisitTime = lastVisit ? lastVisit.time : 0;
     }
 
     var maxResults =
@@ skipping 16 matching lines @@
     this.set('queryState_.sessionList', sessionList);
   },
 
   getSelectedPage: function(selectedPage, range) {
     if (selectedPage == 'history-list' && range != HistoryRange.ALL_TIME)
       return 'history-grouped-list';
 
     return selectedPage;
   },
 
-  syncedTabsSelected_(selectedPage) {

[tsergeant, 2016/06/06 04:33:16]

From the Dept. Of Why Did This Ever Work, apparently this is valid syntax to
declare a function?

[calamity, 2016/06/07 04:46:04]

Oops + wat

[Dan Beam, 2016/06/08 01:18:38]

http://es6-features.org/#MethodProperties

[tsergeant, 2016/06/08 02:53:53]

Aaaaahhhh, interesting.

+  syncedTabsSelected_: function(selectedPage) {
     return selectedPage == 'history-synced-device-manager';
+  },
+
+  /**
+   * True if the backend is searching using a new search term.

[calamity, 2016/06/07 04:46:04]

This is a bit weird. It's not immediately obvious from the method name that we
care about new non-incremental searches. isSearchSpinnerShown_ or
shouldShowSpinner_ perhaps? Then it makes sense that there would be some policy
described in the definition.

[tsergeant, 2016/06/07 06:54:54]

Done. As discussed, also renamed the `processing` property.

+   * @param {boolean} querying
+   * @param {boolean} incremental
+   * @param {string} searchTerm
+   * @return {boolean}
+   * @private
+   */
+  isSearching_: function(querying, incremental, searchTerm) {
+    return querying && !incremental && searchTerm != '';
   }
 });