cc : Add layer_list to LayerTreeImpl and build it for tests

cc : Add layer_list to LayerTreeImpl and build it for tests

Right now, we do a layer tree walk for iteration over all
layers on impl-side (LayerListIterator). Once we start
pushing layer list instead of layer tree during
commit/activation, we will use layer_list instead(layers
will be added to layer_list in stacking  order during
commit/activation). A lot of tests build layer
tree on the impl-side and don't go through
commit/activation. So, we need to explicitly build the
layer_list for these tests.

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35
Cr-Commit-Position: refs/heads/master@{#398100}

[jaydasika, 2016-06-04 00:20:59]

Description was changed from

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

BUG=568874
==========

to

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

BUG=568874
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-06-04 01:15:54]

Description was changed from

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

BUG=568874
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

Right now, we do a layer tree walk for iteration over all layers on impl-side
(LayerListIterator). Once we start pushing layer list instead of layer tree
during commit/activation, we will use layer_list to iterate over all layers
(layers will be added to layer_list in stacking order during commit/activation).
A lot of tests build layer tree on the impl-side and don't go through
commit/activation. So, we need to explicitly build the layer_list for these
tests.

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-06-04 01:16:27]

Description was changed from

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

Right now, we do a layer tree walk for iteration over all layers on impl-side
(LayerListIterator). Once we start pushing layer list instead of layer tree
during commit/activation, we will use layer_list to iterate over all layers
(layers will be added to layer_list in stacking order during commit/activation).
A lot of tests build layer tree on the impl-side and don't go through
commit/activation. So, we need to explicitly build the layer_list for these
tests.

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

Right now, we do a layer tree walk for iteration over all
layers on impl-side (LayerListIterator). Once we start
pushing layer list instead of layer tree during 
commit/activation, we will use layer_list to iterate over 
all layers (layers will be added to layer_list in stacking 
order during commit/activation). A lot of tests build layer 
tree on the impl-side and don't go through 
commit/activation. So, we need to explicitly build the 
layer_list for these tests.

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-06-04 01:17:08]

Description was changed from

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

Right now, we do a layer tree walk for iteration over all
layers on impl-side (LayerListIterator). Once we start
pushing layer list instead of layer tree during 
commit/activation, we will use layer_list to iterate over 
all layers (layers will be added to layer_list in stacking 
order during commit/activation). A lot of tests build layer 
tree on the impl-side and don't go through 
commit/activation. So, we need to explicitly build the 
layer_list for these tests.

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

Right now, we do a layer tree walk for iteration over all
layers on impl-side (LayerListIterator). Once we start
pushing layer list instead of layer tree during 
commit/activation, we will use layer_list instead(layers will be added to
layer_list in stacking 
order during commit/activation). A lot of tests build layer 
tree on the impl-side and don't go through 
commit/activation. So, we need to explicitly build the 
layer_list for these tests.

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-06-04 01:17:23]

Description was changed from

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

Right now, we do a layer tree walk for iteration over all
layers on impl-side (LayerListIterator). Once we start
pushing layer list instead of layer tree during 
commit/activation, we will use layer_list instead(layers will be added to
layer_list in stacking 
order during commit/activation). A lot of tests build layer 
tree on the impl-side and don't go through 
commit/activation. So, we need to explicitly build the 
layer_list for these tests.

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

Right now, we do a layer tree walk for iteration over all
layers on impl-side (LayerListIterator). Once we start
pushing layer list instead of layer tree during 
commit/activation, we will use layer_list instead(layers
will be added to layer_list in stacking  order during 
commit/activation). A lot of tests build layer 
tree on the impl-side and don't go through 
commit/activation. So, we need to explicitly build the 
layer_list for these tests.

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-06-04 01:18:47]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-06-04 01:18:48]

Reviewing Patch 1 will be easier. Patch 2 is just renaming.

[ajuma, 2016-06-06 14:22:32]

lgtm

https://codereview.chromium.org/2032303004/diff/20001/cc/trees/layer_tree_impl.h
File cc/trees/layer_tree_impl.h (right):

https://codereview.chromium.org/2032303004/diff/20001/cc/trees/layer_tree_imp...
cc/trees/layer_tree_impl.h:138: void BuildLayerListForTesting();
Should this be private instead of public? (Will tests ever need to call this
directly instead of via BuildLayerListAndPropertyTreesForTesting?)

[jaydasika, 2016-06-06 18:11:56]

https://codereview.chromium.org/2032303004/diff/20001/cc/trees/layer_tree_impl.h
File cc/trees/layer_tree_impl.h (right):

https://codereview.chromium.org/2032303004/diff/20001/cc/trees/layer_tree_imp...
cc/trees/layer_tree_impl.h:138: void BuildLayerListForTesting();
On 2016/06/06 14:22:32, ajuma wrote:
> Should this be private instead of public? (Will tests ever need to call this
> directly instead of via BuildLayerListAndPropertyTreesForTesting?)

Making it private for now.

[jaydasika, 2016-06-06 18:12:04]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-06-06 18:12:04]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2032303004/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-06-06 18:12:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2032303004/40001

[commit-bot: I haz the power, 2016-06-06 19:44:41]

Description was changed from

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

Right now, we do a layer tree walk for iteration over all
layers on impl-side (LayerListIterator). Once we start
pushing layer list instead of layer tree during 
commit/activation, we will use layer_list instead(layers
will be added to layer_list in stacking  order during 
commit/activation). A lot of tests build layer 
tree on the impl-side and don't go through 
commit/activation. So, we need to explicitly build the 
layer_list for these tests.

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

Right now, we do a layer tree walk for iteration over all
layers on impl-side (LayerListIterator). Once we start
pushing layer list instead of layer tree during 
commit/activation, we will use layer_list instead(layers
will be added to layer_list in stacking  order during 
commit/activation). A lot of tests build layer 
tree on the impl-side and don't go through 
commit/activation. So, we need to explicitly build the 
layer_list for these tests.

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-06-06 19:44:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-06 19:47:09]

Description was changed from

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

Right now, we do a layer tree walk for iteration over all
layers on impl-side (LayerListIterator). Once we start
pushing layer list instead of layer tree during 
commit/activation, we will use layer_list instead(layers
will be added to layer_list in stacking  order during 
commit/activation). A lot of tests build layer 
tree on the impl-side and don't go through 
commit/activation. So, we need to explicitly build the 
layer_list for these tests.

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Add layer_list to LayerTreeImpl and build it for tests

Right now, we do a layer tree walk for iteration over all
layers on impl-side (LayerListIterator). Once we start
pushing layer list instead of layer tree during
commit/activation, we will use layer_list instead(layers
will be added to layer_list in stacking  order during
commit/activation). A lot of tests build layer
tree on the impl-side and don't go through
commit/activation. So, we need to explicitly build the
layer_list for these tests.

BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35
Cr-Commit-Position: refs/heads/master@{#398100}
==========

[commit-bot: I haz the power, 2016-06-06 19:47:11]

Patchset 3 (id:??) landed as
https://crrev.com/4340ea0bedd552170d50ca6ff91fe094c5b16b35
Cr-Commit-Position: refs/heads/master@{#398100}