Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2032303003: Add smoke test for UsbService::GetDevices. (Closed)

Created:
4 years, 6 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 6 months ago
Reviewers:
juncai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add smoke test for UsbService::GetDevices. This test initializes the USB service and calls GetDevices() to exercise the native USB device enumeration path on all platforms. Since we cannot guarantee that a particular piece of hardware is connected the result of this call is not checked. Tested enabled by --enable-gadget-tests provide deeper converage when matching hardware is available. BUG=None Committed: https://crrev.com/1812419e01d1ff037574323597e4508a6660e9a6 Cr-Commit-Position: refs/heads/master@{#397850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M device/test/test_device_client.h View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_service_unittest.cc View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 6 months ago (2016-06-03 22:38:02 UTC) #2
juncai
LGTM.
4 years, 6 months ago (2016-06-03 23:27:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032303003/1
4 years, 6 months ago (2016-06-03 23:41:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 00:03:57 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 00:07:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1812419e01d1ff037574323597e4508a6660e9a6
Cr-Commit-Position: refs/heads/master@{#397850}

Powered by Google App Engine
This is Rietveld 408576698