Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: build/android/pylib/local/device/local_device_test_run.py

Issue 2032253004: [Android] Ensure test names are unique during retry determination. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/local/device/local_device_test_run.py
diff --git a/build/android/pylib/local/device/local_device_test_run.py b/build/android/pylib/local/device/local_device_test_run.py
index 07787cdefeb4a0450b226137e21f0e748abea575..a1ad7ef6ef5a0665d4239838e352de81e6b7863c 100644
--- a/build/android/pylib/local/device/local_device_test_run.py
+++ b/build/android/pylib/local/device/local_device_test_run.py
@@ -162,7 +162,7 @@ class LocalDeviceTestRun(test_run.TestRun):
for n, t in all_test_results.iteritems())
return is_failure(all_test_results.get(name))
- return [t for t in tests if should_retry(self._GetTestName(t))]
+ return [t for t in tests if should_retry(self._GetUniqueTestName(t))]
def GetTool(self, device):
if not str(device) in self._tools:
@@ -174,7 +174,7 @@ class LocalDeviceTestRun(test_run.TestRun):
raise NotImplementedError
# pylint: disable=no-self-use
- def _GetTestName(self, test):
+ def _GetUniqueTestName(self, test):
return test
def _GetTests(self):

Powered by Google App Engine
This is Rietveld 408576698