Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2032253003: mash: Move wm_shelf_types.h into shelf_types.h (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@moveshelfconstants
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move wm_shelf_types.h into shelf_types.h Cleanup from https://codereview.chromium.org/2036353002/ done separately to preserve history. BUG=615155 TEST=compiles Committed: https://crrev.com/a8c9261aa653751d108271b8c15938d78783c692 Cr-Commit-Position: refs/heads/master@{#397909}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -37 lines) Patch
M ash/ash.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/shelf/shelf_types.h View 2 chunks +21 lines, -3 lines 0 comments Download
D ash/common/wm/shelf/wm_shelf_types.h View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
James Cook
sky, please take a look.
4 years, 6 months ago (2016-06-03 21:09:00 UTC) #2
sky
LGTM
4 years, 6 months ago (2016-06-03 22:31:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032253003/20001
4 years, 6 months ago (2016-06-04 06:20:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-04 07:37:05 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 07:39:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8c9261aa653751d108271b8c15938d78783c692
Cr-Commit-Position: refs/heads/master@{#397909}

Powered by Google App Engine
This is Rietveld 408576698