Introduce API to trigger exception on JS execution.

Introduce API to trigger exception on JS execution.

R=jochen@chromium.org, pmarch@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20070

[jochen (gone - plz use gerrit), 2014-03-19 12:31:37]

lgtm

[pmarch, 2014-03-19 12:55:42]

lgtm

lgtm, but some nits

https://codereview.chromium.org/203223013/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/203223013/diff/1/src/api.cc#newcode6518
src/api.cc:6518: Isolate* isolate,
4-space indent?

https://codereview.chromium.org/203223013/diff/1/src/execution.cc
File src/execution.cc (right):

https://codereview.chromium.org/203223013/diff/1/src/execution.cc#newcode82
src/execution.cc:82: isolate->ThrowIllegalOperation();
This does not result in JS code execution when constructing exception, correct?

[Yang, 2014-03-19 13:05:23]

https://codereview.chromium.org/203223013/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/203223013/diff/1/src/api.cc#newcode6518
src/api.cc:6518: Isolate* isolate,
On 2014/03/19 12:55:42, pmarch wrote:
> 4-space indent?

Done.

https://codereview.chromium.org/203223013/diff/1/src/execution.cc
File src/execution.cc (right):

https://codereview.chromium.org/203223013/diff/1/src/execution.cc#newcode82
src/execution.cc:82: isolate->ThrowIllegalOperation();
On 2014/03/19 12:55:42, pmarch wrote:
> This does not result in JS code execution when constructing exception,
correct? 

Right. JS execution happens only if you allocate an Error object. This doesn't
happen with an illegal operation. Also test case works fine.

[Yang, 2014-03-19 13:05:23]

https://codereview.chromium.org/203223013/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/203223013/diff/1/src/api.cc#newcode6518
src/api.cc:6518: Isolate* isolate,
On 2014/03/19 12:55:42, pmarch wrote:
> 4-space indent?

Done.

https://codereview.chromium.org/203223013/diff/1/src/execution.cc
File src/execution.cc (right):

https://codereview.chromium.org/203223013/diff/1/src/execution.cc#newcode82
src/execution.cc:82: isolate->ThrowIllegalOperation();
On 2014/03/19 12:55:42, pmarch wrote:
> This does not result in JS code execution when constructing exception,
correct? 

Right. JS execution happens only if you allocate an Error object. This doesn't
happen with an illegal operation. Also test case works fine.

[Yang, 2014-03-19 13:07:01]

Committed patchset #2 manually as r20070 (presubmit successful).

[tfarina, 2014-03-19 19:14:15]

https://codereview.chromium.org/203223013/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/203223013/diff/20001/include/v8.h#newcode4095
include/v8.h:4095: explicit DisallowJavascriptExecutionScope(Isolate* isolate,
remove explicit? not needed anymore, right?

[Yang, 2014-03-20 09:29:56]

On 2014/03/19 19:14:15, tfarina wrote:
> https://codereview.chromium.org/203223013/diff/20001/include/v8.h
> File include/v8.h (right):
> 
> https://codereview.chromium.org/203223013/diff/20001/include/v8.h#newcode4095
> include/v8.h:4095: explicit DisallowJavascriptExecutionScope(Isolate* isolate,
> remove explicit? not needed anymore, right?

done in https://codereview.chromium.org/206183002