Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5169)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 203223002: Translate bubble for Mac OS X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: groby's review Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 181579d1e79e752239f60b6149c1327f62513144..0e81e7f605ece96cf14ec6a27b44da9a888eba10 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -27,6 +27,7 @@
#include "chrome/browser/signin/signin_ui_util.h"
#include "chrome/browser/themes/theme_service.h"
#include "chrome/browser/themes/theme_service_factory.h"
+#include "chrome/browser/translate/translate_manager.h"
#include "chrome/browser/translate/translate_ui_delegate.h"
#include "chrome/browser/ui/bookmarks/bookmark_editor.h"
#include "chrome/browser/ui/bookmarks/bookmark_utils.h"
@@ -1786,9 +1787,10 @@ enum {
return;
}
- // TODO(hajimehoshi): Set the initial languages correctly.
- std::string sourceLanguage = "xx";
- std::string targetLanguage = "yy";
+ std::string sourceLanguage;
+ std::string targetLanguage;
+ TranslateManager::GetTranslateLanguages(contents,
+ &sourceLanguage, &targetLanguage);
scoped_ptr<TranslateUIDelegate> uiDelegate(
new TranslateUIDelegate(contents, sourceLanguage, targetLanguage));

Powered by Google App Engine
This is Rietveld 408576698