Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2848)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 203223002: Translate bubble for Mac OS X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (rebasing) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index b7de0062b3a695d6c3ae374367a18d3bb7f87e03..4eac979a99b977239ad36f960274bda43011ca3e 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -27,6 +27,7 @@
#include "chrome/browser/signin/signin_ui_util.h"
#include "chrome/browser/themes/theme_service.h"
#include "chrome/browser/themes/theme_service_factory.h"
+#include "chrome/browser/translate/translate_tab_helper.h"
#include "chrome/browser/translate/translate_ui_delegate.h"
#include "chrome/browser/ui/bookmarks/bookmark_editor.h"
#include "chrome/browser/ui/bookmarks/bookmark_utils.h"
@@ -1785,9 +1786,10 @@ enum {
return;
}
- // TODO(hajimehoshi): Set the initial languages correctly.
- std::string sourceLanguage = "xx";
- std::string targetLanguage = "yy";
+ std::string sourceLanguage;
+ std::string targetLanguage;
+ TranslateTabHelper::GetTranslateLanguages(contents,
+ &sourceLanguage, &targetLanguage);
scoped_ptr<TranslateUIDelegate> uiDelegate(
new TranslateUIDelegate(contents, sourceLanguage, targetLanguage));
« no previous file with comments | « chrome/browser/translate/translate_tab_helper.cc ('k') | chrome/browser/ui/cocoa/translate/translate_bubble_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698