Introduce api for incremental wrapper tracing

Introduce api for incremental wrapper tracing

This cl sketches an api for incremental wrapper tracing, but still uses the api
in the stop-the-world fashion. Responsibility to maintain a marking deque is
transfered to the embedder. V8 will still collect wrapper internal fields, but
will send them to the embedder after each incremental gc task. Wrappers must be
sent at latest by the time next oilpan gc runs - so blink can keep all
discovered wrappables alive.

The old api will be cleared after this cl and corresponding blink cl land.

Comments are very welcomed :)

LOG=no
BUG=468240
Committed: https://crrev.com/0f93486699aad9dd6a6c2f9465106351898d840a
Cr-Commit-Position: refs/heads/master@{#36761}

[Marcel Hlopko, 2016-06-03 15:12:08]

hlopko@chromium.org changed reviewers:
+ hpayer@chromium.org, jochen@chromium.org, mlippautz@chromium.org,
ulan@chromium.org

[Marcel Hlopko, 2016-06-03 15:12:38]

Ptal.

[Hannes Payer (out of office), 2016-06-06 12:55:57]

https://codereview.chromium.org/2032213003/diff/1/src/heap/incremental-markin...
File src/heap/incremental-marking.cc (right):

https://codereview.chromium.org/2032213003/diff/1/src/heap/incremental-markin...
src/heap/incremental-marking.cc:751: if (heap_->UsingEmbedderHeapTracer()) {
I would rather have this call in the prologue of the scavenger. This is the
actual location where the bug happens.

https://codereview.chromium.org/2032213003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2032213003/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:2128: while (embedder_heap_tracer()->AdvanceTracing(
Here you are not in an idle scope anymore. You have to finish tracing. I guess
we need some flags that will allow us to specify a FORCE_COMPLETION mode,
similar to V8 marking steps. WDYT?

https://codereview.chromium.org/2032213003/diff/1/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/2032213003/diff/1/src/heap/mark-compact.h#new...
src/heap/mark-compact.h:616: void DumpWrappersToEmbedderHeapTracer();
Let's find a better name for this method. Maybe:
- RegisterWrappersWithEmbedderHeapTracer()

[Marcel Hlopko, 2016-06-06 13:47:44]

https://codereview.chromium.org/2032213003/diff/1/src/heap/incremental-markin...
File src/heap/incremental-marking.cc (right):

https://codereview.chromium.org/2032213003/diff/1/src/heap/incremental-markin...
src/heap/incremental-marking.cc:751: if (heap_->UsingEmbedderHeapTracer()) {
Done.

https://codereview.chromium.org/2032213003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2032213003/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:2128: while (embedder_heap_tracer()->AdvanceTracing(
On 2016/06/06 at 12:55:57, Hannes Payer wrote:
> Here you are not in an idle scope anymore. You have to finish tracing. I guess
we need some flags that will allow us to specify a FORCE_COMPLETION mode,
similar to V8 marking steps. WDYT?

I added AdvanceTracingActions, similar to AdvanceIncrementalMarking. Do you
think it's an overkill here? :)

https://codereview.chromium.org/2032213003/diff/1/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/2032213003/diff/1/src/heap/mark-compact.h#new...
src/heap/mark-compact.h:616: void DumpWrappersToEmbedderHeapTracer();
Done.

[Hannes Payer (out of office), 2016-06-06 14:48:43]

lgtm

https://codereview.chromium.org/2032213003/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2032213003/diff/40001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1629: if (UsingEmbedderHeapTracer()) {
Leave a comment why we have to do that here.

[Marcel Hlopko, 2016-06-06 16:03:27]

The CQ bit was checked by hlopko@chromium.org

[Marcel Hlopko, 2016-06-06 16:03:27]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2032213003/#ps60001
(title: "Add comment")

[commit-bot: I haz the power, 2016-06-06 16:03:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2032213003/60001

[commit-bot: I haz the power, 2016-06-06 16:32:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-06 16:34:08]

Description was changed from

==========
Introduce api for incremental wrapper tracing

This cl sketches an api for incremental wrapper tracing, but still uses the api
in the stop-the-world fashion. Responsibility to maintain a marking deque is
transfered to the embedder. V8 will still collect wrapper internal fields, but
will send them to the embedder after each incremental gc task. Wrappers must be
sent at latest by the time next oilpan gc runs - so blink can keep all
discovered wrappables alive.

The old api will be cleared after this cl and corresponding blink cl land.

Comments are very welcomed :)

LOG=no
BUG=468240
==========

to

==========
Introduce api for incremental wrapper tracing

This cl sketches an api for incremental wrapper tracing, but still uses the api
in the stop-the-world fashion. Responsibility to maintain a marking deque is
transfered to the embedder. V8 will still collect wrapper internal fields, but
will send them to the embedder after each incremental gc task. Wrappers must be
sent at latest by the time next oilpan gc runs - so blink can keep all
discovered wrappables alive.

The old api will be cleared after this cl and corresponding blink cl land.

Comments are very welcomed :)

LOG=no
BUG=468240

Committed: https://crrev.com/0f93486699aad9dd6a6c2f9465106351898d840a
Cr-Commit-Position: refs/heads/master@{#36761}
==========

[commit-bot: I haz the power, 2016-06-06 16:34:09]

Patchset 4 (id:??) landed as
https://crrev.com/0f93486699aad9dd6a6c2f9465106351898d840a
Cr-Commit-Position: refs/heads/master@{#36761}