Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3444)

Unified Diff: cc/trees/property_tree_builder.cc

Issue 2032213002: cc: Put to_target and to_screen behind an accessor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/property_tree.cc ('k') | cc/trees/property_tree_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/property_tree_builder.cc
diff --git a/cc/trees/property_tree_builder.cc b/cc/trees/property_tree_builder.cc
index aa17b8e70614099f70f1b4b1148769460e223e05..0b1e6efd827cdbde0010e8c7598d0468e4c6e1ff 100644
--- a/cc/trees/property_tree_builder.cc
+++ b/cc/trees/property_tree_builder.cc
@@ -503,13 +503,17 @@ bool AddTransformNodeIfNeeded(
ShouldFlattenTransform(layer) || has_surface;
DCHECK_GT(data_from_ancestor.property_trees->effect_tree.size(), 0u);
- node->data.target_id = data_for_children->property_trees->effect_tree
- .Node(data_from_ancestor.render_target)
- ->data.transform_id;
- node->data.content_target_id = data_for_children->property_trees->effect_tree
- .Node(data_for_children->render_target)
- ->data.transform_id;
- DCHECK_NE(node->data.target_id, kInvalidPropertyTreeNodeId);
+ data_for_children->property_trees->transform_tree.SetTargetId(
+ node->id, data_for_children->property_trees->effect_tree
+ .Node(data_from_ancestor.render_target)
+ ->data.transform_id);
+ data_for_children->property_trees->transform_tree.SetContentTargetId(
+ node->id, data_for_children->property_trees->effect_tree
+ .Node(data_for_children->render_target)
+ ->data.transform_id);
+ DCHECK_NE(
+ data_for_children->property_trees->transform_tree.TargetId(node->id),
+ kInvalidPropertyTreeNodeId);
node->data.has_potential_animation = has_potentially_animated_transform;
node->data.is_currently_animating = layer->TransformIsAnimating();
« no previous file with comments | « cc/trees/property_tree.cc ('k') | cc/trees/property_tree_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698