Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: cc/trees/property_tree.h

Issue 2032213002: cc: Put to_target and to_screen behind an accessor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Put target_id behind accessor Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/draw_property_utils.cc ('k') | cc/trees/property_tree.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_TREES_PROPERTY_TREE_H_ 5 #ifndef CC_TREES_PROPERTY_TREE_H_
6 #define CC_TREES_PROPERTY_TREE_H_ 6 #define CC_TREES_PROPERTY_TREE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 487 matching lines...) Expand 10 before | Expand all | Expand 10 after
498 498
499 const std::vector<int>& nodes_affected_by_inner_viewport_bounds_delta() 499 const std::vector<int>& nodes_affected_by_inner_viewport_bounds_delta()
500 const { 500 const {
501 return nodes_affected_by_inner_viewport_bounds_delta_; 501 return nodes_affected_by_inner_viewport_bounds_delta_;
502 } 502 }
503 const std::vector<int>& nodes_affected_by_outer_viewport_bounds_delta() 503 const std::vector<int>& nodes_affected_by_outer_viewport_bounds_delta()
504 const { 504 const {
505 return nodes_affected_by_outer_viewport_bounds_delta_; 505 return nodes_affected_by_outer_viewport_bounds_delta_;
506 } 506 }
507 507
508 gfx::Transform ToTarget(int id) const;
ajuma 2016/06/03 19:35:29 const gfx::Transform&
509 void SetToTarget(int id, const gfx::Transform& transform);
510 gfx::Transform ToScreen(int id) const;
ajuma 2016/06/03 19:35:29 const gfx::Transform&
511 void SetToScreen(int id, const gfx::Transform& transform);
512 int TargetId(int id) const;
ajuma 2016/06/03 19:35:29 Nit: here and below, s/id/node_id (so it's clearer
513 void SetTargetId(int id, int target_id);
514 int ContentTargetId(int id) const;
515 void SetContentTargetId(int id, int content_target_id);
516
508 gfx::Transform ToScreenSpaceTransformWithoutSublayerScale(int id) const; 517 gfx::Transform ToScreenSpaceTransformWithoutSublayerScale(int id) const;
509 518
510 void ToProtobuf(proto::PropertyTree* proto) const; 519 void ToProtobuf(proto::PropertyTree* proto) const;
511 void FromProtobuf(const proto::PropertyTree& proto, 520 void FromProtobuf(const proto::PropertyTree& proto,
512 std::unordered_map<int, int>* node_id_to_index_map); 521 std::unordered_map<int, int>* node_id_to_index_map);
513 522
514 private: 523 private:
515 // Returns true iff the node at |desc_id| is a descendant of the node at 524 // Returns true iff the node at |desc_id| is a descendant of the node at
516 // |anc_id|. 525 // |anc_id|.
517 bool IsDescendant(int desc_id, int anc_id) const; 526 bool IsDescendant(int desc_id, int anc_id) const;
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
739 748
740 private: 749 private:
741 gfx::Vector2dF inner_viewport_container_bounds_delta_; 750 gfx::Vector2dF inner_viewport_container_bounds_delta_;
742 gfx::Vector2dF outer_viewport_container_bounds_delta_; 751 gfx::Vector2dF outer_viewport_container_bounds_delta_;
743 gfx::Vector2dF inner_viewport_scroll_bounds_delta_; 752 gfx::Vector2dF inner_viewport_scroll_bounds_delta_;
744 }; 753 };
745 754
746 } // namespace cc 755 } // namespace cc
747 756
748 #endif // CC_TREES_PROPERTY_TREE_H_ 757 #endif // CC_TREES_PROPERTY_TREE_H_
OLDNEW
« no previous file with comments | « cc/trees/draw_property_utils.cc ('k') | cc/trees/property_tree.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698