Use clustered serialization for full snapshots.

runtime/vm/class_table.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/atomic.h"
 #include "vm/class_table.h"
 #include "vm/flags.h"
 #include "vm/freelist.h"
 #include "vm/growable_array.h"
 #include "vm/heap.h"
@@ skipping 162 matching lines @@
   }
   ASSERT(table_[index] == 0);
   cls.set_id(index);
   table_[index] = cls.raw();
   if (index >= top_) {
     top_ = index + 1;
   }
 }
 
 
+void ClassTable::RegisterAt(intptr_t index, RawClass* cls) {
+  ASSERT(Thread::Current()->IsMutatorThread());
+  ASSERT(index != kIllegalCid);
+  ASSERT(index >= kNumPredefinedCids);
+  if (index >= capacity_) {
+    // Grow the capacity of the class table.
+    // TODO(koda): Add ClassTable::Grow to share code.
+    intptr_t new_capacity = index + capacity_increment_;
+    if (!Class::is_valid_id(index) || new_capacity < capacity_) {
+      FATAL1("Fatal error in ClassTable::Register: invalid index %" Pd "\n",
+             index);
+    }
+    RawClass** new_table = reinterpret_cast<RawClass**>(
+        malloc(new_capacity * sizeof(RawClass*)));  // NOLINT
+    memmove(new_table, table_, capacity_ * sizeof(RawClass*));
+    ClassHeapStats* new_stats_table = reinterpret_cast<ClassHeapStats*>(
+        realloc(class_heap_stats_table_,
+                new_capacity * sizeof(ClassHeapStats)));  // NOLINT
+    for (intptr_t i = capacity_; i < new_capacity; i++) {
+      new_table[i] = NULL;
+      new_stats_table[i].Initialize();
+    }
+    capacity_ = new_capacity;
+    old_tables_->Add(table_);
+    table_ = new_table;  // TODO(koda): This should use atomics.
+    class_heap_stats_table_ = new_stats_table;
+    ASSERT(capacity_increment_ >= 1);
+  }
+  ASSERT(table_[index] == 0);

[siva, 2016/06/21 23:51:43]

This piece of code is duplicated here and above, maybe you should have a method
ClassTable::EnsureCapacity(intptr_t index); and move this code  there.

The callers can then use this pattern:
  EnsureCapcity(index);
  RegisterAt(index, rawcls);

Then you may not need two versions of RegisterAt

I am always nervous about having a raw pointer being available across a big
chunk of code like this.

[rmacnak, 2016/06/22 19:42:17]

Factored out as AllocateIndex, which ensures capacity and bumps top_.

+  table_[index] = cls;
+  if (index >= top_) {
+    top_ = index + 1;
+  }
+}
+
+
 #if defined(DEBUG)
 void ClassTable::Unregister(intptr_t index) {
   table_[index] = 0;
 }
 #endif
 
 
 void ClassTable::VisitObjectPointers(ObjectPointerVisitor* visitor) {
   ASSERT(visitor != NULL);
   visitor->VisitPointers(reinterpret_cast<RawObject**>(&table_[0]), top_);
@@ skipping 356 matching lines @@
 
 void ClassTable::UpdateLiveNew(intptr_t cid, intptr_t size) {
   ClassHeapStats* stats = PreliminaryStatsAt(cid);
   ASSERT(stats != NULL);
   ASSERT(size >= 0);
   stats->post_gc.AddNew(size);
 }
 
 
 }  // namespace dart