Issue 203213008: Move deferred loading logic from WebMediaPlayerClientImpl to HTMLMediaElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203213008: Move deferred loading logic from WebMediaPlayerClientImpl to HTMLMediaElement. (Closed)

Created:
6 years, 9 months ago by acolwell GONE FROM CHROMIUM

Modified:
6 years, 9 months ago

Reviewers:
adamk

CC:
blink-reviews, jamesr, nessy, Rik, dsinclair, philipj_slow, gasubic, fs, eric.carlson_apple.com, jbroman, danakj, feature-media-reviews_chromium.org, dglazkov+blink, pdr., krit, adamk+blink_chromium.org, Stephen Chennney, vcarbune.chromium, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move deferred loading logic from WebMediaPlayerClientImpl to HTMLMediaElement. BUG=350571 TEST=All layout tests still pass. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169669

Patch Set 1 : Original patch #

Patch Set 2 : Fix Android build. #

Patch Set 3 : Add missing semicolon #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -96 lines)			Patch
M	Source/core/html/HTMLMediaElement.h	View		4 chunks	+6 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View		10 chunks	+48 lines, -13 lines	0 comments	Download
M	Source/platform/graphics/media/MediaPlayer.h	View		3 chunks	+1 line, -7 lines	0 comments	Download
M	Source/web/AssertMatchingEnums.cpp	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/web/WebMediaPlayerClientImpl.h	View	1	3 chunks	+8 lines, -15 lines	0 comments	Download
M	Source/web/WebMediaPlayerClientImpl.cpp	View	1 2	6 chunks	+21 lines, -54 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

https://codereview.chromium.org/192013002/ got reverted because of Android build busters. This just contains the original patch plus ...

6 years, 9 months ago (2014-03-20 16:45:41 UTC) #1

acolwell GONE FROM CHROMIUM

The CQ bit was checked by acolwell@chromium.org

6 years, 9 months ago (2014-03-20 17:20:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/203213008/40001

6 years, 9 months ago (2014-03-20 17:20:12 UTC) #4

Message was sent while issue was closed.

Change committed as 169669

Expand Messages | Collapse Messages