Issue 203213006: Revert 169465 "Move deferred loading logic from WebMediaPlayerCl..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203213006: Revert 169465 "Move deferred loading logic from WebMediaPlayerCl..." (Closed)

Created:
6 years, 9 months ago by Zhenyao Mo

Modified:
6 years, 9 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 169465 "Move deferred loading logic from WebMediaPlayerCl..." Android builders fail compile One exampel: http://chromegw.corp.google.com/i/chromium.webkit/builders/Android%20Builder/builds/36609 > Move deferred loading logic from WebMediaPlayerClientImpl to HTMLMediaElement. > > BUG=350571 > TEST=All layout tests still pass. > > Review URL: https://codereview.chromium.org/192013002 TBR=acolwell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169470

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -70 lines)			Patch
M	trunk/Source/core/html/HTMLMediaElement.h	View	4 chunks	+3 lines, -6 lines	0 comments	Download
M	trunk/Source/core/html/HTMLMediaElement.cpp	View	10 chunks	+13 lines, -48 lines	0 comments	Download
M	trunk/Source/platform/graphics/media/MediaPlayer.h	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	trunk/Source/web/AssertMatchingEnums.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	trunk/Source/web/WebMediaPlayerClientImpl.h	View	4 chunks	+9 lines, -1 line	0 comments	Download
M	trunk/Source/web/WebMediaPlayerClientImpl.cpp	View	5 chunks	+54 lines, -14 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r169470.