chrome/test/chromedriver/chrome_launcher.cc - Issue 203213005: Add HANDLE_EINTR in some places missing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 203213005: Add HANDLE_EINTR in some places missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix mac typo Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome_launcher.cc

diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc

index bba04feea2b8dbf1c6d87149864e92729d154cd1..75d05d33b8401c729fafc66937578c1675fe3505 100644

--- a/chrome/test/chromedriver/chrome_launcher.cc

+++ b/chrome/test/chromedriver/chrome_launcher.cc

@@ -255,7 +255,7 @@ Status LaunchDesktopChrome(

if (!CommandLine::ForCurrentProcess()->HasSwitch("verbose")) {

// Redirect stderr to /dev/null, so that Chrome log spew doesn't confuse

// users.

- devnull.reset(open("/dev/null", O_WRONLY));

+ devnull.reset(HANDLE_EINTR(open("/dev/null", O_WRONLY)));

if (!devnull.is_valid())

return Status(kUnknownError, "couldn't open /dev/null");

no_stderr.push_back(std::make_pair(devnull.get(), STDERR_FILENO));