Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2032043003: Revert of Change chromium.memory.fyi to chromium.memory.full (Closed)

Created:
4 years, 6 months ago by benwells
Modified:
4 years, 6 months ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Change chromium.memory.fyi to chromium.memory.full (patchset #4 id:60001 of https://codereview.chromium.org/2010953002/ ) Reason for revert: The master restart script had a problem with this. Reverting and will reland once troopers have the problems figured out. Original issue's description: > Change chromium.memory.fyi to chromium.memory.full > > This master isn't actually an FYI master, it's really an overflow area > for the rest of the memory tree. > > BUG=597178 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/ec3e72dd7b0e8a080771bdf8831418804cbe8f40 TBR=thestig@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=dpranke@chromium.org BUG=597178 Committed: https://chromium.googlesource.com/chromium/tools/build/+/f650347bb9199e988c442730c3ffdafcd743e98b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4049 lines, -4049 lines) Patch
D masters/master.chromium.memory.full/Makefile View 1 chunk +0 lines, -5 lines 0 comments Download
D masters/master.chromium.memory.full/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D masters/master.chromium.memory.full/buildbot View 1 chunk +0 lines, -4 lines 0 comments Download
D masters/master.chromium.memory.full/buildbot.tac View 1 chunk +0 lines, -11 lines 0 comments Download
D masters/master.chromium.memory.full/master.cfg View 1 chunk +0 lines, -738 lines 0 comments Download
D masters/master.chromium.memory.full/master_site_config.py View 1 chunk +0 lines, -14 lines 0 comments Download
D masters/master.chromium.memory.full/notifier_cfg.py View 1 chunk +0 lines, -142 lines 0 comments Download
D masters/master.chromium.memory.full/slaves.cfg View 1 chunk +0 lines, -284 lines 0 comments Download
A masters/master.chromium.memory.fyi/Makefile View 1 chunk +5 lines, -0 lines 0 comments Download
A masters/master.chromium.memory.fyi/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A masters/master.chromium.memory.fyi/buildbot View 1 chunk +4 lines, -0 lines 0 comments Download
A masters/master.chromium.memory.fyi/buildbot.tac View 1 chunk +11 lines, -0 lines 0 comments Download
A masters/master.chromium.memory.fyi/master.cfg View 1 chunk +738 lines, -0 lines 0 comments Download
A masters/master.chromium.memory.fyi/master_site_config.py View 1 chunk +14 lines, -0 lines 0 comments Download
A masters/master.chromium.memory.fyi/notifier_cfg.py View 1 chunk +142 lines, -0 lines 0 comments Download
A masters/master.chromium.memory.fyi/slaves.cfg View 1 chunk +284 lines, -0 lines 0 comments Download
M masters/master.chromium/templates/announce.html View 5 chunks +6 lines, -6 lines 0 comments Download
M scripts/master/failures_notifier.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/bot_update.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/gatekeeper.json View 2 chunks +5 lines, -5 lines 0 comments Download
M scripts/slave/gatekeeper_trees.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/builders.py View 2 chunks +2 lines, -2 lines 0 comments Download
D scripts/slave/recipe_modules/chromium_tests/chromium_memory_full.py View 1 chunk +0 lines, -114 lines 0 comments Download
A scripts/slave/recipe_modules/chromium_tests/chromium_memory_fyi.py View 1 chunk +114 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/trybots.py View 2 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.py View 2 chunks +2 lines, -2 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Chromium_Linux_ChromeOS_MSan_Builder.json View 1 chunk +0 lines, -441 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Chromium_Linux_MSan_Builder.json View 1 chunk +0 lines, -441 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Chromium_Linux_TSan_Builder.json View 1 chunk +0 lines, -441 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_ChromeOS_MSan_Tests.json View 1 chunk +0 lines, -455 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_MSan_Tests.json View 1 chunk +0 lines, -455 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_TSan_Tests.json View 1 chunk +0 lines, -455 lines 0 comments Download
A scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Chromium_Linux_ChromeOS_MSan_Builder.json View 1 chunk +441 lines, -0 lines 0 comments Download
A scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Chromium_Linux_MSan_Builder.json View 1 chunk +441 lines, -0 lines 0 comments Download
A scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Chromium_Linux_TSan_Builder.json View 1 chunk +441 lines, -0 lines 0 comments Download
A scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_ChromeOS_MSan_Tests.json View 1 chunk +455 lines, -0 lines 0 comments Download
A scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_MSan_Tests.json View 1 chunk +455 lines, -0 lines 0 comments Download
A scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_TSan_Tests.json View 1 chunk +455 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/msan.json View 5 chunks +8 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/tsan.json View 5 chunks +8 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_msan_rel_ng.json View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_msan_rel_ng.json View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_tsan_rel_ng.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/masters_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
benwells
Created Revert of Change chromium.memory.fyi to chromium.memory.full
4 years, 6 months ago (2016-06-03 03:55:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032043003/1
4 years, 6 months ago (2016-06-03 03:55:48 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-03 03:55:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032043003/1
4 years, 6 months ago (2016-06-03 03:57:39 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-03 03:57:41 UTC) #11
estaab
lgtm
4 years, 6 months ago (2016-06-03 04:01:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032043003/1
4 years, 6 months ago (2016-06-03 04:02:09 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/f650347bb9199e988c442730c3ffdafcd743e98b
4 years, 6 months ago (2016-06-03 04:02:30 UTC) #17
Dirk Pranke
4 years, 6 months ago (2016-06-03 04:18:13 UTC) #18
Message was sent while issue was closed. 
lgtm also.

Powered by Google App Engine
This is Rietveld 408576698