Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: include/core/SkPaint.h

Issue 203203003: SkPaint: eliminate some dead bytes in 64-bit build. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/core/SkPaint.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 2
3 /* 3 /*
4 * Copyright 2006 The Android Open Source Project 4 * Copyright 2006 The Android Open Source Project
5 * 5 *
6 * Use of this source code is governed by a BSD-style license that can be 6 * Use of this source code is governed by a BSD-style license that can be
7 * found in the LICENSE file. 7 * found in the LICENSE file.
8 */ 8 */
9 9
10 10
(...skipping 1022 matching lines...) Expand 10 before | Expand all | Expand 10 after
1033 } 1033 }
1034 1034
1035 SK_TO_STRING_NONVIRT() 1035 SK_TO_STRING_NONVIRT()
1036 1036
1037 struct FlatteningTraits { 1037 struct FlatteningTraits {
1038 static void Flatten(SkWriteBuffer& buffer, const SkPaint& paint); 1038 static void Flatten(SkWriteBuffer& buffer, const SkPaint& paint);
1039 static void Unflatten(SkReadBuffer& buffer, SkPaint* paint); 1039 static void Unflatten(SkReadBuffer& buffer, SkPaint* paint);
1040 }; 1040 };
1041 1041
1042 private: 1042 private:
1043 SkTypeface* fTypeface;
1044 SkScalar fTextSize; 1043 SkScalar fTextSize;
1045 SkScalar fTextScaleX; 1044 SkScalar fTextScaleX;
1046 SkScalar fTextSkewX; 1045 SkScalar fTextSkewX;
1046 SkColor fColor;
1047 SkScalar fWidth;
1048 SkScalar fMiterLimit;
1047 1049
1050 SkTypeface* fTypeface;
reed1 2014/03/18 15:04:01 Maybe we can be even more aggressive/clear, and mo
mtklein 2014/03/18 17:00:46 SGTM. Done.
1048 SkPathEffect* fPathEffect; 1051 SkPathEffect* fPathEffect;
1049 SkShader* fShader; 1052 SkShader* fShader;
1050 SkXfermode* fXfermode; 1053 SkXfermode* fXfermode;
1051 SkMaskFilter* fMaskFilter; 1054 SkMaskFilter* fMaskFilter;
1052 SkColorFilter* fColorFilter; 1055 SkColorFilter* fColorFilter;
1053 SkRasterizer* fRasterizer; 1056 SkRasterizer* fRasterizer;
1054 SkDrawLooper* fLooper; 1057 SkDrawLooper* fLooper;
1055 SkImageFilter* fImageFilter; 1058 SkImageFilter* fImageFilter;
1056 SkAnnotation* fAnnotation; 1059 SkAnnotation* fAnnotation;
1057 1060
1058 SkColor fColor;
1059 SkScalar fWidth;
1060 SkScalar fMiterLimit;
1061
1062 union { 1061 union {
1063 struct { 1062 struct {
1064 // all of these bitfields should add up to 32 1063 // all of these bitfields should add up to 32
1065 unsigned fFlags : 16; 1064 unsigned fFlags : 16;
1066 unsigned fTextAlign : 2; 1065 unsigned fTextAlign : 2;
1067 unsigned fCapType : 2; 1066 unsigned fCapType : 2;
1068 unsigned fJoinType : 2; 1067 unsigned fJoinType : 2;
1069 unsigned fStyle : 2; 1068 unsigned fStyle : 2;
1070 unsigned fTextEncoding : 2; // 3 values 1069 unsigned fTextEncoding : 2; // 3 values
1071 unsigned fHinting : 2; 1070 unsigned fHinting : 2;
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
1147 #ifdef SK_BUILD_FOR_ANDROID 1146 #ifdef SK_BUILD_FOR_ANDROID
1148 SkPaintOptionsAndroid fPaintOptionsAndroid; 1147 SkPaintOptionsAndroid fPaintOptionsAndroid;
1149 1148
1150 // In order for the == operator to work properly this must be the last field 1149 // In order for the == operator to work properly this must be the last field
1151 // in the struct so that we can do a memcmp to this field's offset. 1150 // in the struct so that we can do a memcmp to this field's offset.
1152 uint32_t fGenerationID; 1151 uint32_t fGenerationID;
1153 #endif 1152 #endif
1154 }; 1153 };
1155 1154
1156 #endif 1155 #endif
OLDNEW
« no previous file with comments | « no previous file | src/core/SkPaint.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698