Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2032013003: [DevTools] Fix problem with loading source maps (Closed)

Created:
4 years, 6 months ago by kozy
Modified:
4 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix problem with loading source maps Encode not utf8 chunk as base 64 and then decode it on frontend side. BUG=611328 R=dgozman@chromium.org Committed: https://crrev.com/72c30193f0804fff83ed73d92db7d5fc5df6b186 Cr-Commit-Position: refs/heads/master@{#397618}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devtools.js View 1 1 chunk +20 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
kozy
Dmitry, please take a look!
4 years, 6 months ago (2016-06-02 21:40:25 UTC) #1
dgozman
https://codereview.chromium.org/2032013003/diff/1/third_party/WebKit/Source/devtools/front_end/devtools.js File third_party/WebKit/Source/devtools/front_end/devtools.js (right): https://codereview.chromium.org/2032013003/diff/1/third_party/WebKit/Source/devtools/front_end/devtools.js#newcode310 third_party/WebKit/Source/devtools/front_end/devtools.js:310: this._dispatchOnInspectorFrontendAPI("streamWrite", [id, chunk, encoded]); For backwards compatibility you should ...
4 years, 6 months ago (2016-06-02 22:26:19 UTC) #2
dgozman
https://codereview.chromium.org/2032013003/diff/1/third_party/WebKit/Source/devtools/front_end/host/ResourceLoader.js File third_party/WebKit/Source/devtools/front_end/host/ResourceLoader.js (right): https://codereview.chromium.org/2032013003/diff/1/third_party/WebKit/Source/devtools/front_end/host/ResourceLoader.js#newcode39 third_party/WebKit/Source/devtools/front_end/host/ResourceLoader.js:39: request.open("GET", "data:text/plain;base64," + chunk, false); Let's create a helper ...
4 years, 6 months ago (2016-06-02 22:32:12 UTC) #3
kozy
Dmitry, please take a look! https://codereview.chromium.org/2032013003/diff/1/third_party/WebKit/Source/devtools/front_end/devtools.js File third_party/WebKit/Source/devtools/front_end/devtools.js (right): https://codereview.chromium.org/2032013003/diff/1/third_party/WebKit/Source/devtools/front_end/devtools.js#newcode310 third_party/WebKit/Source/devtools/front_end/devtools.js:310: this._dispatchOnInspectorFrontendAPI("streamWrite", [id, chunk, encoded]); ...
4 years, 6 months ago (2016-06-02 23:00:20 UTC) #5
dgozman
lgtm Can we have a test?
4 years, 6 months ago (2016-06-02 23:16:07 UTC) #6
kozy
We need to add this kind of tests for DevTools. Right now we can't add ...
4 years, 6 months ago (2016-06-03 00:32:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032013003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032013003/40001
4 years, 6 months ago (2016-06-03 00:32:49 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-03 03:29:52 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 03:32:14 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/72c30193f0804fff83ed73d92db7d5fc5df6b186
Cr-Commit-Position: refs/heads/master@{#397618}

Powered by Google App Engine
This is Rietveld 408576698