Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2031973003: Use int32_t for duration property of toast (Closed)

Created:
4 years, 6 months ago by yoshiki
Modified:
4 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use int32_t for duration property of toast To match it with the API. Android and mojo API use 32bit int for this property. BUG=none Committed: https://crrev.com/ea1747088f96bcabc50a863445c8580b46ee5884 Cr-Commit-Position: refs/heads/master@{#397833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M ash/system/toast/toast_data.h View 1 chunk +2 lines, -4 lines 0 comments Download
M ash/system/toast/toast_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/toast/toast_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
yoshiki
Oshima-san, PTAL. Thanks
4 years, 6 months ago (2016-06-03 06:48:14 UTC) #5
oshima
On 2016/06/03 06:48:14, yoshiki wrote: > Oshima-san, PTAL. Thanks
4 years, 6 months ago (2016-06-03 16:02:38 UTC) #6
oshima
On 2016/06/03 16:02:38, oshima wrote: > On 2016/06/03 06:48:14, yoshiki wrote: > > Oshima-san, PTAL. ...
4 years, 6 months ago (2016-06-03 16:02:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031973003/20001
4 years, 6 months ago (2016-06-03 21:30:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-03 23:09:40 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 23:10:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea1747088f96bcabc50a863445c8580b46ee5884
Cr-Commit-Position: refs/heads/master@{#397833}

Powered by Google App Engine
This is Rietveld 408576698