Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2031953004: 💴 target_cpu -> current_cpu in chrome/BUILD.gn (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@monochrome
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

target_cpu -> current_cpu in chrome/BUILD.gn BUG=616819 Committed: https://crrev.com/1dfe1f8c72091bf6b3df7a510dd77a796769bf9d Cr-Commit-Position: refs/heads/master@{#398566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (7 generated)
agrieve
4 years, 6 months ago (2016-06-03 17:17:24 UTC) #2
agrieve
4 years, 6 months ago (2016-06-03 17:17:49 UTC) #4
Nico
Lgtm (but I think this is a noop on Windows)
4 years, 6 months ago (2016-06-03 17:23:25 UTC) #5
Nico
Lgtm (but I think this is a noop on Windows)
4 years, 6 months ago (2016-06-03 17:23:26 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2036263002 Patch 20001). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-03 17:32:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031953004/1
4 years, 6 months ago (2016-06-08 14:41:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 15:43:25 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 15:46:52 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dfe1f8c72091bf6b3df7a510dd77a796769bf9d
Cr-Commit-Position: refs/heads/master@{#398566}

Powered by Google App Engine
This is Rietveld 408576698