Issue 203193010: Add UseCounters for the Attr.value getter and setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203193010: Add UseCounters for the Attr.value getter and setter (Closed)

Created:
6 years, 9 months ago by philipj_slow

Modified:
6 years, 9 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, watchdog-blink-watchlist_google.com, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add UseCounters for the Attr.value getter and setter This is to determine if it could be made readonly. The getter is measured to learn the relative usage, and is most likely above any threshold for removal. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169541

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -4 lines)			Patch
M	Source/core/dom/Attr.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	Source/core/dom/Attr.cpp	View	3 chunks	+15 lines, -2 lines	0 comments	Download
M	Source/core/dom/Attr.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/UseCounter.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

Intended to answer the question in https://www.w3.org/Bugs/Public/show_bug.cgi?id=25086#c9

6 years, 9 months ago (2014-03-19 09:15:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/203193010/1

6 years, 9 months ago (2014-03-19 11:10:33 UTC) #4

Message was sent while issue was closed.

Change committed as 169541

Expand Messages | Collapse Messages