Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 203193002: Web Animations API: Initialise FontBuilder when resolving keyframes (Closed)

Created:
6 years, 9 months ago by alancutter (OOO until 2018)
Modified:
6 years, 9 months ago
Reviewers:
dstockwell, esprehn
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Web Animations API: Initialise FontBuilder when resolving keyframes FontBuilder must be properly initialised before font properties can be applied to a RenderStyle. BUG=352505, 352506 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169437

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, --1 lines) Patch
A LayoutTests/web-animations-api/font-builder-crash.html View 1 chunk +15 lines, -0 lines 0 comments Download
A + LayoutTests/web-animations-api/font-builder-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
alancutter (OOO until 2018)
6 years, 9 months ago (2014-03-18 08:20:11 UTC) #1
dstockwell
lgtm
6 years, 9 months ago (2014-03-18 08:22:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/203193002/1
6 years, 9 months ago (2014-03-18 08:23:04 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 08:25:56 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-18 08:25:56 UTC) #5
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-18 09:23:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/203193002/1
6 years, 9 months ago (2014-03-18 09:23:43 UTC) #7
esprehn
lgtm
6 years, 9 months ago (2014-03-18 09:23:58 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 09:52:54 UTC) #9
Message was sent while issue was closed.
Change committed as 169437

Powered by Google App Engine
This is Rietveld 408576698