[Cronet]Make delaying sending request headers explicit in bidirectional stream

[Cronet]Make delaying sending request headers explicit in bidirectional stream

Always delaying sending request headers when
disableAutoFlush is not safe (in the case of bidirectional
streaming). Because server might be expecting request
headers before sending a response, while client might only
call SendData/SendvData after server responds.

This CL adds an explicit flag to tell
net::BidirectionalStream when to delay sending request
headers and coalesce them with data frames in
SendData/SendvData.

BUG=599902
TBR=mef@chromium.org

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1992953004
Cr-Commit-Position: refs/heads/master@{#397567}
(cherry picked from commit bcb0f86e685b9d603bebb97e9574e2e0e32948c2)

[xunjieli, 2016-06-03 21:45:01]

Misha, this fixes a crasher (see internal bug 29123954 for more details). This
CL merges it into M52.

[xunjieli, 2016-06-03 21:45:26]

Description was changed from

==========
[Cronet]Make delaying sending request headers explicit in bidirectional stream

Always delaying sending request headers when
disableAutoFlush is not safe (in the case of bidirectional
streaming). Because server might be expecting request
headers before sending a response, while client might only
call SendData/SendvData after server responds.

This CL adds an explicit flag to tell
net::BidirectionalStream when to delay sending request
headers and coalesce them with data frames in
SendData/SendvData.

BUG=599902

TBR=mef@chromium.org


Review-Url: https://codereview.chromium.org/1992953004
Cr-Commit-Position: refs/heads/master@{#397567}
(cherry picked from commit bcb0f86e685b9d603bebb97e9574e2e0e32948c2)
==========

to

==========
[Cronet]Make delaying sending request headers explicit in bidirectional stream

Always delaying sending request headers when
disableAutoFlush is not safe (in the case of bidirectional
streaming). Because server might be expecting request
headers before sending a response, while client might only
call SendData/SendvData after server responds.

This CL adds an explicit flag to tell
net::BidirectionalStream when to delay sending request
headers and coalesce them with data frames in
SendData/SendvData.

BUG=599902

TBR=mef@chromium.org

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1992953004
Cr-Commit-Position: refs/heads/master@{#397567}
(cherry picked from commit bcb0f86e685b9d603bebb97e9574e2e0e32948c2)
==========

[xunjieli, 2016-06-03 22:00:36]

On 2016/06/03 21:45:01, xunjieli wrote:
> Misha, this fixes a crasher (see internal bug 29123954 for more details). This
> CL merges it into M52.

net_unittests and Cronet tests are passing.

[xunjieli, 2016-06-03 22:01:48]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2016-06-03 22:03:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031923006/1

[commit-bot: I haz the power, 2016-06-03 22:05:09]

Description was changed from

==========
[Cronet]Make delaying sending request headers explicit in bidirectional stream

Always delaying sending request headers when
disableAutoFlush is not safe (in the case of bidirectional
streaming). Because server might be expecting request
headers before sending a response, while client might only
call SendData/SendvData after server responds.

This CL adds an explicit flag to tell
net::BidirectionalStream when to delay sending request
headers and coalesce them with data frames in
SendData/SendvData.

BUG=599902

TBR=mef@chromium.org

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1992953004
Cr-Commit-Position: refs/heads/master@{#397567}
(cherry picked from commit bcb0f86e685b9d603bebb97e9574e2e0e32948c2)
==========

to

==========
[Cronet]Make delaying sending request headers explicit in bidirectional stream

Always delaying sending request headers when
disableAutoFlush is not safe (in the case of bidirectional
streaming). Because server might be expecting request
headers before sending a response, while client might only
call SendData/SendvData after server responds.

This CL adds an explicit flag to tell
net::BidirectionalStream when to delay sending request
headers and coalesce them with data frames in
SendData/SendvData.

BUG=599902

TBR=mef@chromium.org

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1992953004
Cr-Commit-Position: refs/heads/master@{#397567}
(cherry picked from commit bcb0f86e685b9d603bebb97e9574e2e0e32948c2)
==========

[commit-bot: I haz the power, 2016-06-03 22:05:10]

Committed patchset #1 (id:1)