Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2031923004: 💯 target_cpu -> current_cpu in mojo/BUILD.gn (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@monochrome
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

target_cpu -> current_cpu in mojo/BUILD.gn BUG=616819 Committed: https://crrev.com/d3e99c39e092e6154d2f2f70c803395d1eeeb668 Cr-Commit-Position: refs/heads/master@{#398565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
agrieve
4 years, 6 months ago (2016-06-03 17:18:49 UTC) #2
Ken Rockot(use gerrit already)
Huh. I'm not sure this condition should even exist, but rs lgtm
4 years, 6 months ago (2016-06-03 17:20:54 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2036263002 Patch 20001). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-03 17:22:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031923004/1
4 years, 6 months ago (2016-06-08 14:40:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 15:42:30 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 15:44:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3e99c39e092e6154d2f2f70c803395d1eeeb668
Cr-Commit-Position: refs/heads/master@{#398565}

Powered by Google App Engine
This is Rietveld 408576698