tools/mb/mb_config.pyl - Issue 2031903002: Update GN files w/ changes needed to make sanitizers work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/mb/mb_config.pyl

Issue 2031903002: Update GN files w/ changes needed to make sanitizers work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rework to add comments, drop the symbolized config Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/mb/mb_config.pyl

diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl

index 5b50656de80b0d6752f64f0d87cc2991701e6997..7455d72e7a1f7ed4f44ca72e1014c1f859ce9730 100644

--- a/tools/mb/mb_config.pyl

+++ b/tools/mb/mb_config.pyl

@@ -2222,8 +2222,9 @@

'gyp_defines': 'test_isolation_mode=prepare',

+ # TODO(dpranke): Remove the symbolized config after the bots are gone.

'symbolized': {

- 'gn_args': 'error', # TODO(GYP): add an equivalent flag for this

+ 'gn_args': 'symbolized=true',

'gyp_defines':

'release_extra_cflags="-O1 -fno-inline-functions -fno-inline"',

« build/common.gypi ('K') | « third_party/instrumented_libraries/BUILD.gn ('k') | no next file » | no next file with comments »