Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1566)

Unified Diff: build/common.gypi

Issue 2031903002: Update GN files w/ changes needed to make sanitizers work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move buildconfig changes to build/config Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 30eda8155ed89faa6811e39b373b6749f15ee408..a9c8f1ddefe7e811ae8472237beab9a075404911 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -632,8 +632,7 @@
# http://crbug.com/105550
'use_canvas_skia%': 0,
- # Set to "tsan", "memcheck", or "drmemory" to configure the build to work
- # with one of those tools.
+ # Set to "drmemory" to configure the build to work with DrMemory.
'build_for_tool%': '',
'wix_path%': '<(DEPTH)/third_party/wix',
@@ -2289,27 +2288,6 @@
'v8_target_arch': 'arm64',
}],
- # On valgrind bots, override the optimizer settings so we don't inline too
- # much and make the stacks harder to figure out.
- #
- # TODO(rnk): Kill off variables that no one else uses and just implement
- # them under a build_for_tool== condition.
- ['build_for_tool=="memcheck" or build_for_tool=="tsan"', {
- # gcc flags
- 'mac_debug_optimization': '1',
- 'mac_release_optimization': '1',
- 'release_optimize': '1',
- 'no_gc_sections': 1,
- 'debug_extra_cflags': '-g -fno-inline -fno-omit-frame-pointer '
- '-fno-builtin -fno-optimize-sibling-calls',
- 'release_extra_cflags': '-g -fno-inline -fno-omit-frame-pointer '
- '-fno-builtin -fno-optimize-sibling-calls',
-
- 'release_valgrind_build': 1,
- 'werror': '',
- 'component': 'static_library',
- }],
-
# Build tweaks for DrMemory.
# TODO(rnk): Combine with tsan config to share the builder.
# http://crbug.com/108155
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698