Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: build/common.gypi

Issue 2031903002: Update GN files w/ changes needed to make sanitizers work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rework to add comments, drop the symbolized config Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 614 matching lines...) Expand 10 before | Expand all | Expand 10 after
625 # Enable plugin installation by default. 625 # Enable plugin installation by default.
626 'enable_plugin_installation%': 1, 626 'enable_plugin_installation%': 1,
627 627
628 # Specifies whether to use canvas_skia.cc in place of platform 628 # Specifies whether to use canvas_skia.cc in place of platform
629 # specific implementations of gfx::Canvas. Affects text drawing in the 629 # specific implementations of gfx::Canvas. Affects text drawing in the
630 # Chrome UI. 630 # Chrome UI.
631 # TODO(asvitkine): Enable this on all platforms and delete this flag. 631 # TODO(asvitkine): Enable this on all platforms and delete this flag.
632 # http://crbug.com/105550 632 # http://crbug.com/105550
633 'use_canvas_skia%': 0, 633 'use_canvas_skia%': 0,
634 634
635 # Set to "tsan", "memcheck", or "drmemory" to configure the build to work 635 # Set to "drmemory" to configure the build to work with DrMemory.
636 # with one of those tools.
637 'build_for_tool%': '', 636 'build_for_tool%': '',
638 637
639 'wix_path%': '<(DEPTH)/third_party/wix', 638 'wix_path%': '<(DEPTH)/third_party/wix',
640 639
641 # Supervised users are enabled by default. 640 # Supervised users are enabled by default.
642 'enable_supervised_users%': 1, 641 'enable_supervised_users%': 1,
643 642
644 'enable_mdns%' : 0, 643 'enable_mdns%' : 0,
645 'enable_service_discovery%': 0, 644 'enable_service_discovery%': 0,
646 'enable_hangout_services_extension%': 0, 645 'enable_hangout_services_extension%': 0,
(...skipping 1631 matching lines...) Expand 10 before | Expand all | Expand 10 after
2278 # Use a just-built, MSan-instrumented libc++ instead of the system-wide 2277 # Use a just-built, MSan-instrumented libc++ instead of the system-wide
2279 # libstdc++. This is required to avoid false positive reports whenever 2278 # libstdc++. This is required to avoid false positive reports whenever
2280 # the C++ standard library is used. 2279 # the C++ standard library is used.
2281 'use_custom_libcxx%': 1, 2280 'use_custom_libcxx%': 1,
2282 # Running the V8-generated code on an ARM simulator is a powerful hack 2281 # Running the V8-generated code on an ARM simulator is a powerful hack
2283 # that allows the tool to see the memory accesses from JITted code. 2282 # that allows the tool to see the memory accesses from JITted code.
2284 # Without this flag, JS code causes false positive reports from MSan. 2283 # Without this flag, JS code causes false positive reports from MSan.
2285 'v8_target_arch': 'arm64', 2284 'v8_target_arch': 'arm64',
2286 }], 2285 }],
2287 2286
2288 # On valgrind bots, override the optimizer settings so we don't inline too
2289 # much and make the stacks harder to figure out.
2290 #
2291 # TODO(rnk): Kill off variables that no one else uses and just implement
2292 # them under a build_for_tool== condition.
2293 ['build_for_tool=="memcheck" or build_for_tool=="tsan"', {
Dirk Pranke 2016/06/03 04:17:29 The best we can tell, "memcheck" is now gone (no m
krasin 2016/06/03 04:43:51 I confirm that (spoken with eugenis@)
2294 # gcc flags
2295 'mac_debug_optimization': '1',
2296 'mac_release_optimization': '1',
2297 'release_optimize': '1',
2298 'no_gc_sections': 1,
2299 'debug_extra_cflags': '-g -fno-inline -fno-omit-frame-pointer '
2300 '-fno-builtin -fno-optimize-sibling-calls',
2301 'release_extra_cflags': '-g -fno-inline -fno-omit-frame-pointer '
2302 '-fno-builtin -fno-optimize-sibling-calls',
2303
2304 'release_valgrind_build': 1,
2305 'werror': '',
2306 'component': 'static_library',
2307 }],
2308
2309 # Build tweaks for DrMemory. 2287 # Build tweaks for DrMemory.
2310 # TODO(rnk): Combine with tsan config to share the builder. 2288 # TODO(rnk): Combine with tsan config to share the builder.
2311 # http://crbug.com/108155 2289 # http://crbug.com/108155
2312 ['build_for_tool=="drmemory"', { 2290 ['build_for_tool=="drmemory"', {
2313 # These runtime checks force initialization of stack vars which blocks 2291 # These runtime checks force initialization of stack vars which blocks
2314 # DrMemory's uninit detection. 2292 # DrMemory's uninit detection.
2315 'win_debug_RuntimeChecks': '0', 2293 'win_debug_RuntimeChecks': '0',
2316 # Iterator debugging is slow. 2294 # Iterator debugging is slow.
2317 'win_debug_disable_iterator_debugging': '1', 2295 'win_debug_disable_iterator_debugging': '1',
2318 # Try to disable optimizations that mess up stacks in a release build. 2296 # Try to disable optimizations that mess up stacks in a release build.
(...skipping 4023 matching lines...) Expand 10 before | Expand all | Expand 10 after
6342 # settings in target dicts. SYMROOT is a special case, because many other 6320 # settings in target dicts. SYMROOT is a special case, because many other
6343 # Xcode variables depend on it, including variables such as 6321 # Xcode variables depend on it, including variables such as
6344 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6322 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6345 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6323 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6346 # files to appear (when present) in the UI as actual files and not red 6324 # files to appear (when present) in the UI as actual files and not red
6347 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6325 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6348 # and therefore SYMROOT, needs to be set at the project level. 6326 # and therefore SYMROOT, needs to be set at the project level.
6349 'SYMROOT': '<(DEPTH)/xcodebuild', 6327 'SYMROOT': '<(DEPTH)/xcodebuild',
6350 }, 6328 },
6351 } 6329 }
OLDNEW
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698