xfa/fxfa/parser/xfa_object_imp.cpp - Issue 2031873003: Get rid of NULLs in xfa/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_object_imp.cpp

Issue 2031873003: Get rid of NULLs in xfa/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@nullptr_fpdfsdk

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_object_imp.cpp

diff --git a/xfa/fxfa/parser/xfa_object_imp.cpp b/xfa/fxfa/parser/xfa_object_imp.cpp

index cfe65ed864176ea99d33195c9ed51c7af8e58c6c..67f7fd744a585b257f9d98c37189c12d3dc34aee 100644

--- a/xfa/fxfa/parser/xfa_object_imp.cpp

+++ b/xfa/fxfa/parser/xfa_object_imp.cpp

@@ -4045,7 +4045,7 @@ FX_BOOL CXFA_Node::SetObject(XFA_ATTRIBUTE eAttr,

FX_BOOL CXFA_Node::TryObject(XFA_ATTRIBUTE eAttr, void*& pData) {

void* pKey = XFA_GetMapKey_Element(GetClassID(), eAttr);

pData = GetUserData(pKey);

- return pData != nullptr;

+ return !!pData;

}

FX_BOOL CXFA_Node::SetValue(XFA_ATTRIBUTE eAttr,

XFA_ATTRIBUTETYPE eType,

« no previous file with comments | « xfa/fxfa/parser/xfa_object.h ('k') | xfa/fxfa/parser/xfa_parser.h » ('j') | no next file with comments »