Get rid of NULLs in xfa/

xfa/fxfa/parser/xfa_script_resolveprocessor.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/parser/xfa_script_resolveprocessor.h"
 
 #include "core/fxcrt/include/fx_ext.h"
 #include "xfa/fxfa/parser/xfa_doclayout.h"
 #include "xfa/fxfa/parser/xfa_document.h"
 #include "xfa/fxfa/parser/xfa_localemgr.h"
 #include "xfa/fxfa/parser/xfa_object.h"
 #include "xfa/fxfa/parser/xfa_parser.h"
 #include "xfa/fxfa/parser/xfa_script.h"
 #include "xfa/fxfa/parser/xfa_script_imp.h"
 #include "xfa/fxfa/parser/xfa_script_nodehelper.h"
 #include "xfa/fxfa/parser/xfa_utils.h"
 
 CXFA_ResolveProcessor::CXFA_ResolveProcessor(void)
     : m_pNodeHelper(new CXFA_NodeHelper), m_iCurStart(0) {}
 
 CXFA_ResolveProcessor::~CXFA_ResolveProcessor(void) {
   delete m_pNodeHelper;
 }
 
 int32_t CXFA_ResolveProcessor::XFA_ResolveNodes(CXFA_ResolveNodesData& rnd) {
-  if (rnd.m_CurNode == NULL) {
+  if (!rnd.m_CurNode)
     return -1;
-  }
+
   if (!rnd.m_CurNode->IsNode()) {
     if (rnd.m_dwStyles & XFA_RESOLVENODE_Attributes) {
       return XFA_ResolveNodes_ForAttributeRs(rnd.m_CurNode, rnd,
                                              rnd.m_wsName.AsStringC());
     }
     return 0;
   }
   if (rnd.m_dwStyles & XFA_RESOLVENODE_AnyChild) {
     return XFA_ResolveNodes_AnyChild(rnd);
   }
@@ skipping 36 matching lines @@
   int32_t nRet = XFA_ResolveNodes_Normal(rnd);
   if (nRet < 1 && rnd.m_uHashName == XFA_HASHCODE_Xfa) {
     rnd.m_Nodes.Add(rnd.m_pSC->GetDocument()->GetRoot());
   }
   return rnd.m_Nodes.GetSize();
 }
 int32_t CXFA_ResolveProcessor::XFA_ResolveNodes_AnyChild(
     CXFA_ResolveNodesData& rnd) {
   CFX_WideString wsName = rnd.m_wsName;
   CFX_WideString wsCondition = rnd.m_wsCondition;
-  CXFA_Node* findNode = NULL;
+  CXFA_Node* findNode = nullptr;
   CXFA_NodeArray siblings;
   FX_BOOL bClassName = FALSE;
   if (wsName.GetAt(0) == '#') {
     bClassName = TRUE;
     wsName = wsName.Right(wsName.GetLength() - 1);
   }
   findNode = m_pNodeHelper->XFA_ResolveNodes_GetOneChild(
       ToNode(rnd.m_CurNode), wsName.c_str(), bClassName);
-  if (findNode == NULL) {
+  if (!findNode)
     return 0;
-  }
+
   if (wsCondition.IsEmpty()) {
     rnd.m_Nodes.Add(findNode);
     return rnd.m_Nodes.GetSize();
   }
   m_pNodeHelper->XFA_CountSiblings(findNode, XFA_LOGIC_Transparent,
                                    (CXFA_NodeArray*)&rnd.m_Nodes, bClassName);
   XFA_ResolveNode_FilterCondition(rnd, wsCondition);
   return rnd.m_Nodes.GetSize();
 }
 int32_t CXFA_ResolveProcessor::XFA_ResolveNodes_Dollar(
@@ skipping 110 matching lines @@
   XFA_HashCode uNameHash = rnd.m_uHashName;
   CFX_WideString& wsCondition = rnd.m_wsCondition;
   CXFA_ResolveNodesData rndFind;
   rndFind.m_wsName = rnd.m_wsName;
   rndFind.m_wsCondition = rnd.m_wsCondition;
   rndFind.m_pSC = rnd.m_pSC;
   rndFind.m_nLevel = rnd.m_nLevel + 1;
   rndFind.m_uHashName = uNameHash;
   CXFA_NodeArray children;
   CXFA_NodeArray properties;
-  CXFA_Node* pVariablesNode = NULL;
-  CXFA_Node* pPageSetNode = NULL;
+  CXFA_Node* pVariablesNode = nullptr;
+  CXFA_Node* pPageSetNode = nullptr;
   CXFA_Node* pChild = curNode->GetNodeItem(XFA_NODEITEM_FirstChild);
   while (pChild) {
     if (pChild->GetClassID() == XFA_ELEMENT_Variables) {
       pVariablesNode = pChild;
       pChild = pChild->GetNodeItem(XFA_NODEITEM_NextSibling);
       continue;
     } else if (pChild->GetClassID() == XFA_ELEMENT_PageSet) {
       pPageSetNode = pChild;
       pChild = pChild->GetNodeItem(XFA_NODEITEM_NextSibling);
       continue;
@@ skipping 104 matching lines @@
         nodes.Add(childProperty);
       }
     }
     if (nodes.GetSize() > nNum) {
       XFA_ResolveNode_FilterCondition(rnd, wsCondition);
       if (nodes.GetSize() > 0) {
         return 1;
       }
       return 0;
     }
-    CXFA_Node* pProp = NULL;
+    CXFA_Node* pProp = nullptr;
     if (XFA_ELEMENT_Subform == curNode->GetClassID() &&
         XFA_HASHCODE_Occur == uNameHash) {
       CXFA_Node* pInstanceManager =
           curNode->AsNode()->GetInstanceMgrOfSubform();
       if (pInstanceManager) {
         pProp = pInstanceManager->GetProperty(0, XFA_ELEMENT_Occur, TRUE);
       }
     } else {
       const XFA_ELEMENTINFO* pElement =
           XFA_GetElementByName(wsName.AsStringC());
@@ skipping 276 matching lines @@
       break;
     }
   }
   if (bAll) {
     if (rnd.m_dwStyles & XFA_RESOLVENODE_CreateNode) {
       if (rnd.m_dwStyles & XFA_RESOLVENODE_Bind) {
         m_pNodeHelper->m_pCreateParent = ToNode(rnd.m_CurNode);
         m_pNodeHelper->m_iCreateCount = 1;
         findNodes.RemoveAll();
         m_pNodeHelper->m_iCurAllStart = -1;
-        m_pNodeHelper->m_pAllStartParent = NULL;
+        m_pNodeHelper->m_pAllStartParent = nullptr;
       } else {
         if (m_pNodeHelper->m_iCurAllStart == -1) {
           m_pNodeHelper->m_iCurAllStart = m_iCurStart;
           m_pNodeHelper->m_pAllStartParent = ToNode(rnd.m_CurNode);
         }
       }
     } else if (rnd.m_dwStyles & XFA_RESOLVENODE_BindNew) {
       if (m_pNodeHelper->m_iCurAllStart == -1) {
         m_pNodeHelper->m_iCurAllStart = m_iCurStart;
       }
@@ skipping 152 matching lines @@
   if (m_pNodeHelper->XFA_CreateNode_ForCondition(wsNextCondition)) {
     if (m_pNodeHelper->m_eLastCreateType == XFA_ELEMENT_DataGroup) {
       iIndex = 0;
     } else {
       iIndex = iCount - 1;
     }
   } else {
     iIndex = iCount - 1;
   }
 }