Get rid of NULLs in xfa/

xfa/fxfa/app/xfa_ffwidgetacc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/app/xfa_ffwidgetacc.h"
 
 #include <algorithm>
 #include <memory>
@@ skipping 17 matching lines @@
 #include "xfa/fxfa/parser/xfa_script_imp.h"
 #include "xfa/fxjse/value.h"
 
 static void XFA_FFDeleteCalcData(void* pData) {
   if (pData) {
     delete ((CXFA_CalcData*)pData);
   }
 }
 
 static XFA_MAPDATABLOCKCALLBACKINFO gs_XFADeleteCalcData = {
-    XFA_FFDeleteCalcData, NULL};
+    XFA_FFDeleteCalcData, nullptr};
 
 class CXFA_WidgetLayoutData {
  public:
   CXFA_WidgetLayoutData() : m_fWidgetHeight(-1) {}
   virtual ~CXFA_WidgetLayoutData() {}
 
   FX_FLOAT m_fWidgetHeight;
 };
 
 class CXFA_TextLayoutData : public CXFA_WidgetLayoutData {
@@ skipping 78 matching lines @@
   std::unique_ptr<CFX_FloatArray> m_pFieldSplitArray;
 };
 
 class CXFA_TextEditData : public CXFA_FieldLayoutData {
  public:
 };
 
 class CXFA_ImageEditData : public CXFA_FieldLayoutData {
  public:
   CXFA_ImageEditData()
-      : m_pDIBitmap(NULL),
+      : m_pDIBitmap(nullptr),
         m_bNamedImage(FALSE),
         m_iImageXDpi(0),
         m_iImageYDpi(0) {}
 
   ~CXFA_ImageEditData() override {
     if (m_pDIBitmap && !m_bNamedImage)
       delete m_pDIBitmap;
   }
 
   FX_BOOL LoadImageData(CXFA_WidgetAcc* pAcc) {
@@ skipping 65 matching lines @@
     } break;
     case XFA_ELEMENT_ExclGroup: {
       CXFA_Node* pNextChild = m_pNode->GetNodeItem(
           XFA_NODEITEM_FirstChild, XFA_OBJECTTYPE_ContainerNode);
       while (pNextChild) {
         CXFA_Node* pChild = pNextChild;
         CXFA_WidgetAcc* pAcc = (CXFA_WidgetAcc*)pChild->GetWidgetData();
         if (!pAcc) {
           continue;
         }
-        CXFA_Value defValue(NULL);
+        CXFA_Value defValue(nullptr);
         if (wsValue.IsEmpty() && (defValue = pAcc->GetDefaultValue())) {
           defValue.GetChildValueContent(wsValue);
           SetValue(wsValue, XFA_VALUEPICTURE_Raw);
           pAcc->SetValue(wsValue, XFA_VALUEPICTURE_Raw);
         } else {
           CXFA_Node* pItems = pChild->GetChild(0, XFA_ELEMENT_Items);
           if (!pItems) {
             continue;
           }
           CFX_WideString itemText;
@@ skipping 39 matching lines @@
   } else {
     CFDE_XMLNode* pXMLNode = pBind->GetXMLMappingNode();
     ASSERT(pXMLNode && pXMLNode->GetType() == FDE_XMLNODE_Element);
     static_cast<CFDE_XMLElement*>(pXMLNode)->SetString(L"href", wsHref);
   }
 }
 
 CXFA_WidgetAcc* CXFA_WidgetAcc::GetExclGroup() {
   CXFA_Node* pExcl = m_pNode->GetNodeItem(XFA_NODEITEM_Parent);
   if (!pExcl || pExcl->GetClassID() != XFA_ELEMENT_ExclGroup) {
-    return NULL;
+    return nullptr;
   }
   return (CXFA_WidgetAcc*)pExcl->GetWidgetData();
 }
 CXFA_FFDocView* CXFA_WidgetAcc::GetDocView() {
   return m_pDocView;
 }
 CXFA_FFDoc* CXFA_WidgetAcc::GetDoc() {
   return (CXFA_FFDoc*)m_pDocView->GetDoc();
 }
 CXFA_FFApp* CXFA_WidgetAcc::GetApp() {
@@ skipping 397 matching lines @@
         }
         if (pGlobalData->m_Globals.Find(this) < 0) {
           pGlobalData->m_Globals.Add(this);
         }
       }
     }
   }
   if (pRetValue)
     *pRetValue = pTmpRetValue.release();
 
-  pContext->SetNodesOfRunScript(NULL);
+  pContext->SetNodesOfRunScript(nullptr);
   return iRet;
 }
 CXFA_FFWidget* CXFA_WidgetAcc::GetNextWidget(CXFA_FFWidget* pWidget) {
   CXFA_LayoutItem* pLayout = nullptr;
   if (pWidget) {
     pLayout = pWidget->GetNext();
   } else {
     pLayout = m_pDocView->GetXFALayout()->GetLayoutItem(m_pNode);
   }
   return static_cast<CXFA_FFWidget*>(pLayout);
 }
 void CXFA_WidgetAcc::UpdateUIDisplay(CXFA_FFWidget* pExcept) {
-  CXFA_FFWidget* pWidget = NULL;
+  CXFA_FFWidget* pWidget = nullptr;
   while ((pWidget = GetNextWidget(pWidget)) != nullptr) {
     if (pWidget == pExcept || !pWidget->IsLoaded() ||
         (GetUIType() != XFA_ELEMENT_CheckButton && pWidget->IsFocused())) {
       continue;
     }
     pWidget->UpdateFWLData();
     pWidget->AddInvalidateRect();
   }
 }
 
@@ skipping 742 matching lines @@
 CXFA_TextLayout* CXFA_WidgetAcc::GetCaptionTextLayout() {
   return m_pLayoutData
              ? static_cast<CXFA_FieldLayoutData*>(m_pLayoutData.get())
                    ->m_pCapTextLayout.get()
              : nullptr;
 }
 CXFA_TextLayout* CXFA_WidgetAcc::GetTextLayout() {
   return m_pLayoutData
              ? static_cast<CXFA_TextLayoutData*>(m_pLayoutData.get())
                    ->GetTextLayout()
-             : NULL;
+             : nullptr;
 }
 CFX_DIBitmap* CXFA_WidgetAcc::GetImageImage() {
   return m_pLayoutData
              ? static_cast<CXFA_ImageLayoutData*>(m_pLayoutData.get())
                    ->m_pDIBitmap
-             : NULL;
+             : nullptr;
 }
 CFX_DIBitmap* CXFA_WidgetAcc::GetImageEditImage() {
   return m_pLayoutData
              ? static_cast<CXFA_ImageEditData*>(m_pLayoutData.get())
                    ->m_pDIBitmap
-             : NULL;
+             : nullptr;
 }
 
 void CXFA_WidgetAcc::SetImageImage(CFX_DIBitmap* newImage) {
   CXFA_ImageLayoutData* pData =
       static_cast<CXFA_ImageLayoutData*>(m_pLayoutData.get());
   if (pData->m_pDIBitmap == newImage)
     return;
 
   if (pData->m_pDIBitmap && !pData->m_bNamedImage)
     delete pData->m_pDIBitmap;
@@ skipping 66 matching lines @@
       if (wsContentType == FX_WSTRC(L"text/html")) {
         bRichText = TRUE;
       }
     }
     return m_pTextNode;
   }
   if (m_eType == XFA_TEXTPROVIDERTYPE_Text) {
     CXFA_Node* pElementNode = m_pWidgetAcc->GetNode();
     CXFA_Node* pValueNode = pElementNode->GetChild(0, XFA_ELEMENT_Value);
     if (!pValueNode) {
-      return NULL;
+      return nullptr;
     }
     CXFA_Node* pChildNode = pValueNode->GetNodeItem(XFA_NODEITEM_FirstChild);
     if (pChildNode && pChildNode->GetClassID() == XFA_ELEMENT_ExData) {
       CFX_WideString wsContentType;
       pChildNode->GetAttribute(XFA_ATTRIBUTE_ContentType, wsContentType, FALSE);
       if (wsContentType == FX_WSTRC(L"text/html")) {
         bRichText = TRUE;
       }
     }
     return pChildNode;
   } else if (m_eType == XFA_TEXTPROVIDERTYPE_Datasets) {
     CXFA_Node* pBind = m_pWidgetAcc->GetDatasets();
     CFDE_XMLNode* pXMLNode = pBind->GetXMLMappingNode();
     ASSERT(pXMLNode);
     for (CFDE_XMLNode* pXMLChild =
              pXMLNode->GetNodeItem(CFDE_XMLNode::FirstChild);
          pXMLChild;
          pXMLChild = pXMLChild->GetNodeItem(CFDE_XMLNode::NextSibling)) {
       if (pXMLChild->GetType() == FDE_XMLNODE_Element) {
         CFDE_XMLElement* pElement = static_cast<CFDE_XMLElement*>(pXMLChild);
         if (XFA_RecognizeRichText(pElement)) {
           bRichText = TRUE;
         }
       }
     }
     return pBind;
   } else if (m_eType == XFA_TEXTPROVIDERTYPE_Caption) {
     CXFA_Node* pCaptionNode =
         m_pWidgetAcc->GetNode()->GetChild(0, XFA_ELEMENT_Caption);
-    if (pCaptionNode == NULL) {
-      return NULL;
-    }
+    if (!pCaptionNode)
+      return nullptr;
+
     CXFA_Node* pValueNode = pCaptionNode->GetChild(0, XFA_ELEMENT_Value);
-    if (pValueNode == NULL) {
-      return NULL;
-    }
+    if (!pValueNode)
+      return nullptr;
+
     CXFA_Node* pChildNode = pValueNode->GetNodeItem(XFA_NODEITEM_FirstChild);
     if (pChildNode && pChildNode->GetClassID() == XFA_ELEMENT_ExData) {
       CFX_WideString wsContentType;
       pChildNode->GetAttribute(XFA_ATTRIBUTE_ContentType, wsContentType, FALSE);
       if (wsContentType == FX_WSTRC(L"text/html")) {
         bRichText = TRUE;
       }
     }
     return pChildNode;
   }
   CXFA_Node* pItemNode =
       m_pWidgetAcc->GetNode()->GetChild(0, XFA_ELEMENT_Items);
-  if (pItemNode == NULL) {
-    return NULL;
-  }
+  if (!pItemNode)
+    return nullptr;
+
   CXFA_Node* pNode = pItemNode->GetNodeItem(XFA_NODEITEM_FirstChild);
   while (pNode) {
     CFX_WideStringC wsName;
     pNode->TryCData(XFA_ATTRIBUTE_Name, wsName);
     if (m_eType == XFA_TEXTPROVIDERTYPE_Rollover &&
         wsName == FX_WSTRC(L"rollover")) {
       return pNode;
     }
     if (m_eType == XFA_TEXTPROVIDERTYPE_Down && wsName == FX_WSTRC(L"down")) {
       return pNode;
     }
     pNode = pNode->GetNodeItem(XFA_NODEITEM_NextSibling);
   }
-  return NULL;
+  return nullptr;
 }
 CXFA_Para CXFA_TextProvider::GetParaNode() {
   if (m_eType == XFA_TEXTPROVIDERTYPE_Text) {
     return m_pWidgetAcc->GetPara();
   }
   CXFA_Node* pNode = m_pWidgetAcc->GetNode()->GetChild(0, XFA_ELEMENT_Caption);
   return CXFA_Para(pNode->GetChild(0, XFA_ELEMENT_Para));
 }
 CXFA_Font CXFA_TextProvider::GetFontNode() {
   if (m_eType == XFA_TEXTPROVIDERTYPE_Text) {
@@ skipping 18 matching lines @@
                                         FX_BOOL bRaw,
                                         const CFX_WideString& wsAttr,
                                         CFX_WideString& wsValue) {
   if (m_eType != XFA_TEXTPROVIDERTYPE_Text) {
     return FALSE;
   }
   if (bURI) {
     CXFA_Node* pWidgetNode = m_pWidgetAcc->GetNode();
     CXFA_Node* pParent = pWidgetNode->GetNodeItem(XFA_NODEITEM_Parent);
     CXFA_Document* pDocument = pWidgetNode->GetDocument();
-    CXFA_Node* pIDNode = NULL;
-    CXFA_WidgetAcc* pEmbAcc = NULL;
+    CXFA_Node* pIDNode = nullptr;
+    CXFA_WidgetAcc* pEmbAcc = nullptr;
     if (pParent) {
       pIDNode = pDocument->GetNodeByID(pParent, wsAttr.AsStringC());
     }
     if (!pIDNode) {
       pIDNode = pDocument->GetNodeByID(
           ToNode(pDocument->GetXFAObject(XFA_HASHCODE_Form)),
           wsAttr.AsStringC());
     }
     if (pIDNode) {
       pEmbAcc = (CXFA_WidgetAcc*)pIDNode->GetWidgetData();
     }
     if (pEmbAcc) {
       pEmbAcc->GetValue(wsValue, XFA_VALUEPICTURE_Display);
       return TRUE;
     }
   }
   return FALSE;
 }